* [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten
@ 2005-08-01 22:02 Jiri Slaby
2005-08-05 23:45 ` Jiri Slaby
2005-08-06 19:12 ` Domen Puncer
0 siblings, 2 replies; 4+ messages in thread
From: Jiri Slaby @ 2005-08-01 22:02 UTC (permalink / raw)
To: Linux Kernel Mailing List
Hello.
Could you send me critics and bugs?
Could somebody test it (but NOT now)?
Thanks.
drivers/char/isicom.c | 1610
++++++++++++++++++++++++-------------------------
include/linux/isicom.h | 8
2 files changed, 817 insertions(+), 801 deletions(-)
Here it is (about 65 KiB):
http://www.fi.muni.cz/~xslaby/lnx/isi.txt
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@gmail.com ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten
2005-08-01 22:02 [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten Jiri Slaby
@ 2005-08-05 23:45 ` Jiri Slaby
2005-08-06 19:12 ` Domen Puncer
1 sibling, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2005-08-05 23:45 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Linux Kernel Mailing List
Jiri Slaby napsal(a):
> Could somebody test it (but NOT now)?
Ok, could anybody test it now, if no problems were discovered, please?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten
2005-08-01 22:02 [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten Jiri Slaby
2005-08-05 23:45 ` Jiri Slaby
@ 2005-08-06 19:12 ` Domen Puncer
2005-08-07 0:17 ` Jiri Slaby
1 sibling, 1 reply; 4+ messages in thread
From: Domen Puncer @ 2005-08-06 19:12 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Linux Kernel Mailing List
On 02/08/05 00:02 +0200, Jiri Slaby wrote:
> Hello.
> Could you send me critics and bugs?
You have much bigger chances of someone reviewing the patch if you
at least split code changes and whitespace/type cleanups. 65k is a lot.
> Could somebody test it (but NOT now)?
> Thanks.
>
> drivers/char/isicom.c | 1610
> ++++++++++++++++++++++++-------------------------
> include/linux/isicom.h | 8
> 2 files changed, 817 insertions(+), 801 deletions(-)
>
> Here it is (about 65 KiB):
It should deserve a few bytes of description ;-)
> http://www.fi.muni.cz/~xslaby/lnx/isi.txt
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten
2005-08-06 19:12 ` Domen Puncer
@ 2005-08-07 0:17 ` Jiri Slaby
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2005-08-07 0:17 UTC (permalink / raw)
To: Domen Puncer; +Cc: Linux Kernel Mailing List
Domen Puncer napsal(a):
>You have much bigger chances of someone reviewing the patch if you
>at least split code changes and whitespace/type cleanups. 65k is a lot.
>
>
Ok, 3 patches:
http://www.fi.muni.cz/~xslaby/lnx/isi_main.txt
this changes many lines of code, adds hotplug, firmware loading, add one
fixme, because i have really no idea, what device feed to
request_firmware when isa card is used
http://www.fi.muni.cz/~xslaby/lnx/isi_us.txt
unsigned short changed to u16 and similar, where it expect sized operands
http://www.fi.muni.cz/~xslaby/lnx/isi_w.txt
changes trying to convert code into CodingStyle
removed trailing spaces, some lines longer than 80 split
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@gmail.com ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-08-07 0:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-01 22:02 [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten Jiri Slaby
2005-08-05 23:45 ` Jiri Slaby
2005-08-06 19:12 ` Domen Puncer
2005-08-07 0:17 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).