From: Thomas Winischhofer <thomas@winischhofer.net>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/video/sis/ macros for old kernels removal
Date: Mon, 08 Aug 2005 19:19:17 +0200 [thread overview]
Message-ID: <42F79415.2020709@winischhofer.net> (raw)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Arjan van de Ven wrote:
> On Mon, 2005-08-08 at 17:23 +0200, Jiri Slaby wrote:
> > Jiri Slaby napsal(a):
> >
>>> This patch removes some #ifs, which controls kernel version (2.4 or
>>> like), so the code could be removed with the macros.
>>> linux/version.h inclusions also removed.
>>
>> Sorry, this was bad idea. X includes some of these file, doesn't it?
>
> X can't depend on the version of the kernel anyway; the "version" in
> version.h has no relation with the running kernel anyway (or with the
> version of the kernel that will be used to run the X binaries on)
No good idea anyway. X does, of course, not "include" these files, but
they are reused. I don't want to maintain two different versions of the
files.
Furthermore, I have a quite big sisfb update in the queue which I intend
to submit after 2.6.13 is out. It, amongst others, removes a lot of 2.4
related stuff.
It's best to leave it alone for now.
Thomas
- --
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net http://www.winischhofer.net/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFC95QVzydIRAktyUcRAkrHAJ98HUOIk7LjHQKWhgMVQqqaiH4mQACePYeG
Xl3yGGJeINOsgTT2FOdpQI8=
=aItr
-----END PGP SIGNATURE-----
next reply other threads:[~2005-08-08 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-08 17:19 Thomas Winischhofer [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-08-08 15:10 [PATCH] drivers/video/sis/ macros for old kernels removal Jiri Slaby
2005-08-08 15:23 ` Jiri Slaby
2005-08-08 15:48 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42F79415.2020709@winischhofer.net \
--to=thomas@winischhofer.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox