From: Michael Krufky <mkrufky@m1k.net>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, mkrufky@linuxtv.org
Subject: [PATCH] resubmit: Remove experimental tda9887 code from lgdt330x.c
Date: Mon, 08 Aug 2005 15:56:43 -0400 [thread overview]
Message-ID: <42F7B8FB.30904@m1k.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
Andrew-
I've already sent this patch to you on LKML, but it is possible that it
may have gotten lost, as I sent this patch in the middle of a thread,
entitled:
Re: [PATCH] DVB: lgdt330x frontend: some bug fixes & add lgdt3303 support
This patch removes some experimental tda9887 code from lgdt330x.c (where
is does NOT belong) that was unintentionally included by a previous patch.
Signed-off-by: Michael Krufky <mkrufky@m1k.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
--
Michael Krufky
[-- Attachment #2: lgdt330x-remove-tda9887.patch --]
[-- Type: text/plain, Size: 1509 bytes --]
linux/drivers/media/dvb/frontends/lgdt330x.c | 35 -------------------
1 files changed, 35 deletions(-)
diff -u linux-2.6.13/drivers/media/dvb/frontends/lgdt330x.c linux/drivers/media/dvb/frontends/lgdt330x.c
--- linux-2.6.13/drivers/media/dvb/frontends/lgdt330x.c 2005-08-08 09:46:25.000000000 +0000
+++ linux/drivers/media/dvb/frontends/lgdt330x.c 2005-08-08 09:48:24.000000000 +0000
@@ -172,38 +172,6 @@
}
}
-#ifdef MUTE_TDA9887
-static int i2c_write_ntsc_demod (struct lgdt330x_state* state, u8 buf[2])
-{
- struct i2c_msg msg =
- { .addr = 0x43,
- .flags = 0,
- .buf = buf,
- .len = 2 };
- int err;
-
- if ((err = i2c_transfer(state->i2c, &msg, 1)) != 1) {
- printk(KERN_WARNING "lgdt330x: %s error (addr %02x <- %02x, err = %i)\n", __FUNCTION__, msg.buf[0], msg.buf[1], err);
- if (err < 0)
- return err;
- else
- return -EREMOTEIO;
- }
- return 0;
-}
-
-static void fiddle_with_ntsc_if_demod(struct lgdt330x_state* state)
-{
- // Experimental code
- u8 buf0[] = {0x00, 0x20};
- u8 buf1[] = {0x01, 0x00};
- u8 buf2[] = {0x02, 0x00};
-
- i2c_write_ntsc_demod(state, buf0);
- i2c_write_ntsc_demod(state, buf1);
- i2c_write_ntsc_demod(state, buf2);
-}
-#endif
static int lgdt330x_init(struct dvb_frontend* fe)
{
@@ -267,9 +235,6 @@
chip_name = "LGDT3303";
err = i2c_write_demod_bytes(state, lgdt3303_init_data,
sizeof(lgdt3303_init_data));
-#ifdef MUTE_TDA9887
- fiddle_with_ntsc_if_demod(state);
-#endif
break;
default:
chip_name = "undefined";
reply other threads:[~2005-08-08 19:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42F7B8FB.30904@m1k.net \
--to=mkrufky@m1k.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox