2.6.13-rc5-mm1, mii.c functions linking problem

2.6.13-rc5-mm1, mii.c functions linking problem

[Jiri Slaby]

Hello, i find out this problem:
#make O=../bu allmodconfig
...
#make O=../bu all
...
  LD      .tmp_vmlinux1
drivers/built-in.o(.text+0x63c87): In function `sis190_get_settings':
/l/latest/xxx/drivers/net/sis190.c:1656: undefined reference to 
`mii_ethtool_gset'
drivers/built-in.o(.text+0x63c96): In function `sis190_set_settings':
/l/latest/xxx/drivers/net/sis190.c:1663: undefined reference to 
`mii_ethtool_sset'
drivers/built-in.o(.text+0x63d04): In function `sis190_nway_reset':
/l/latest/xxx/drivers/net/sis190.c:1699: undefined reference to 
`mii_nway_restart'
drivers/built-in.o(.text+0x63d2d): In function `sis190_ioctl':
/l/latest/xxx/drivers/net/sis190.c:1732: undefined reference to 
`generic_mii_ioctl'
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [all] Error 2
# objdump ../bu/drivers/net/mii.o -t|grep gener
00000018 l     O __kcrctab      00000004 __kcrctab_generic_mii_ioctl
0000005e l     O __ksymtab_strings      00000012 __kstrtab_generic_mii_ioctl
00000030 l     O __ksymtab      00000008 __ksymtab_generic_mii_ioctl
131e7c56 g       *ABS*  00000000 __crc_generic_mii_ioctl
00000635 g     F .text  00000130 generic_mii_ioctl
#objdump ../bu/drivers/net/built-in.o -t|grep gener
00000000         *UND*  00000000 generic_mii_ioctl
# objdump ../bu/drivers/built-in.o -t|grep generic_mii
00000000         *UND*  00000000 generic_mii_ioctl
...

-- 
Jiri Slaby         www.fi.muni.cz/~xslaby
~\-/~      jirislaby@gmail.com      ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10

[-mm patch] SIS190 must select MII

[Adrian Bunk]

On Tue, Aug 09, 2005 at 02:26:31AM +0200, Jiri Slaby wrote:
> Hello, i find out this problem:
> #make O=../bu allmodconfig
> ...
> #make O=../bu all
> ...
>  LD      .tmp_vmlinux1
> drivers/built-in.o(.text+0x63c87): In function `sis190_get_settings':
> /l/latest/xxx/drivers/net/sis190.c:1656: undefined reference to 
> `mii_ethtool_gset'
>...

Obvious bug in git-netdev-sis190.patch, fix below.

cu
Adrian


<--  snip  -->


SIS190 must select MII since it's using it.

While I was editing the Kconfig entry, I also converted the spaces to 
tabs.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.13-rc5-mm1-full/drivers/net/Kconfig.old	2005-08-09 02:32:14.000000000 +0200
+++ linux-2.6.13-rc5-mm1-full/drivers/net/Kconfig	2005-08-09 02:33:12.000000000 +0200
@@ -1924,14 +1924,15 @@
 	  If in doubt, say Y.
 
 config SIS190
-      tristate "SiS190 gigabit ethernet support"
-      depends on PCI
-      select CRC32
-      ---help---
-        Say Y here if you have a SiS 190 PCI Gigabit Ethernet adapter.
+	tristate "SiS190 gigabit ethernet support"
+	depends on PCI
+	select CRC32
+	select MII
+	---help---
+	  Say Y here if you have a SiS 190 PCI Gigabit Ethernet adapter.
 
-        To compile this driver as a module, choose M here: the module
-        will be called sis190.  This is recommended.
+	  To compile this driver as a module, choose M here: the module
+	  will be called sis190.  This is recommended.
 
 config SKGE
 	tristate "New SysKonnect GigaEthernet support (EXPERIMENTAL)"