From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Paul McKenney <paul.mckenney@us.ibm.com>
Cc: Dipankar Sarma <dipankar@in.ibm.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [patch 2/7] mm: PG_free flag
Date: Thu, 11 Aug 2005 22:22:07 +1000 [thread overview]
Message-ID: <42FB42EF.1040401@yahoo.com.au> (raw)
In-Reply-To: <42FB42BD.6020808@yahoo.com.au>
[-- Attachment #1: Type: text/plain, Size: 33 bytes --]
2/7
--
SUSE Labs, Novell Inc.
[-- Attachment #2: mm-PG_free-flag.patch --]
[-- Type: text/plain, Size: 2886 bytes --]
In a future patch we can no longer rely on page_count being stable at any
time, so we can no longer overload PagePrivate && page_count == 0 to mean
the page is free and on the buddy lists.
Index: linux-2.6/include/linux/page-flags.h
===================================================================
--- linux-2.6.orig/include/linux/page-flags.h
+++ linux-2.6/include/linux/page-flags.h
@@ -76,6 +76,8 @@
#define PG_nosave_free 18 /* Free, should not be written */
#define PG_uncached 19 /* Page has been mapped as uncached */
+#define PG_free 20 /* Page is on the free lists */
+
/*
* Global page accounting. One instance per CPU. Only unsigned longs are
* allowed.
@@ -306,6 +308,10 @@ extern void __mod_page_state(unsigned lo
#define SetPageUncached(page) set_bit(PG_uncached, &(page)->flags)
#define ClearPageUncached(page) clear_bit(PG_uncached, &(page)->flags)
+#define PageFree(page) test_bit(PG_free, &(page)->flags)
+#define __SetPageFree(page) __set_bit(PG_free, &(page)->flags)
+#define __ClearPageFree(page) __clear_bit(PG_free, &(page)->flags)
+
struct page; /* forward declaration */
int test_clear_page_dirty(struct page *page);
Index: linux-2.6/mm/page_alloc.c
===================================================================
--- linux-2.6.orig/mm/page_alloc.c
+++ linux-2.6/mm/page_alloc.c
@@ -114,7 +114,8 @@ static void bad_page(const char *functio
1 << PG_slab |
1 << PG_swapcache |
1 << PG_writeback |
- 1 << PG_reserved );
+ 1 << PG_reserved |
+ 1 << PG_free );
set_page_count(page, 0);
reset_page_mapcount(page);
page->mapping = NULL;
@@ -191,12 +192,12 @@ static inline unsigned long page_order(s
static inline void set_page_order(struct page *page, int order) {
page->private = order;
- __SetPagePrivate(page);
+ __SetPageFree(page);
}
static inline void rmv_page_order(struct page *page)
{
- __ClearPagePrivate(page);
+ __ClearPageFree(page);
page->private = 0;
}
@@ -242,9 +243,7 @@ __find_combined_index(unsigned long page
*/
static inline int page_is_buddy(struct page *page, int order)
{
- if (PagePrivate(page) &&
- (page_order(page) == order) &&
- page_count(page) == 0)
+ if (PageFree(page) && (page_order(page) == order))
return 1;
return 0;
}
@@ -327,7 +326,8 @@ static inline void free_pages_check(cons
1 << PG_slab |
1 << PG_swapcache |
1 << PG_writeback |
- 1 << PG_reserved )))
+ 1 << PG_reserved |
+ 1 << PG_free )))
bad_page(function, page);
if (PageDirty(page))
__ClearPageDirty(page);
@@ -456,7 +456,8 @@ static void prep_new_page(struct page *p
1 << PG_slab |
1 << PG_swapcache |
1 << PG_writeback |
- 1 << PG_reserved )))
+ 1 << PG_reserved |
+ 1 << PG_free )))
bad_page(__FUNCTION__, page);
page->flags &= ~(1 << PG_uptodate | 1 << PG_error |
next prev parent reply other threads:[~2005-08-11 12:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 12:18 [patch 0/7] lockless pagecache 2 Nick Piggin
2005-08-11 12:21 ` [patch 1/7] mm: remove PageReserved rollup Nick Piggin
2005-08-11 12:22 ` Nick Piggin [this message]
2005-08-11 12:22 ` [patch 3/7] mm: speculative get_page Nick Piggin
2005-08-11 12:25 ` [patch 4/7] radix-tree: lookup_slot Nick Piggin
2005-08-11 12:25 ` [patch 5/7] radix-tree: lockless readside Nick Piggin
2005-08-11 12:28 ` [patch 6/7] mm: lockless pagecache Nick Piggin
2005-08-11 12:28 ` [patch 7/7] mm: spinlock tree_lock Nick Piggin
2005-08-11 13:58 ` [patch 6/7] mm: lockless pagecache Pekka Enberg
2005-08-11 14:06 ` Nick Piggin
2005-08-12 1:49 ` Paul E. McKenney
2005-08-12 4:04 ` Nick Piggin
2005-08-12 1:37 ` [patch 5/7] radix-tree: lockless readside Paul E. McKenney
2005-08-12 3:59 ` Nick Piggin
2005-08-12 4:38 ` Nick Piggin
2005-08-12 7:53 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42FB42EF.1040401@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paul.mckenney@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox