* suspect code in drivers/char/agp/generic.c
@ 2005-08-12 1:06 Jeremy Fitzhardinge
2005-08-12 3:28 ` Dave Jones
0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Fitzhardinge @ 2005-08-12 1:06 UTC (permalink / raw)
To: David Mosberger, Andrew Morton; +Cc: Linux Kernel Mailing List
I was just looking at agp_copy_info(), which contains this code:
318 if (bridge->mode & AGPSTAT_MODE_3_0)
319 info->mode = bridge->mode & ~AGP3_RESERVED_MASK;
320 else
321 info->mode = bridge->mode & ~AGP2_RESERVED_MASK;
322 info->mode = bridge->mode;
This looks wrong to me, since line 322 overrides the previous 4 lines'
work...
I have no idea whether this is actually causing a problem, but I'd
thought I'd call attention to it.
J
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: suspect code in drivers/char/agp/generic.c
2005-08-12 1:06 suspect code in drivers/char/agp/generic.c Jeremy Fitzhardinge
@ 2005-08-12 3:28 ` Dave Jones
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jones @ 2005-08-12 3:28 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: David Mosberger, Andrew Morton, Linux Kernel Mailing List
On Thu, Aug 11, 2005 at 06:06:55PM -0700, Jeremy Fitzhardinge wrote:
> I was just looking at agp_copy_info(), which contains this code:
>
> 318 if (bridge->mode & AGPSTAT_MODE_3_0)
> 319 info->mode = bridge->mode & ~AGP3_RESERVED_MASK;
> 320 else
> 321 info->mode = bridge->mode & ~AGP2_RESERVED_MASK;
> 322 info->mode = bridge->mode;
>
> This looks wrong to me, since line 322 overrides the previous 4 lines'
> work...
>
> I have no idea whether this is actually causing a problem, but I'd
> thought I'd call attention to it.
Ugh, that crept in when the multiple gart support got added.
Line 322 shouldn't be there. I'll nuke it in agpgart.git
Whilst its clearly wrong, I'd like the corrected version to take a quick
spin in -mm before we add this to 2.6.13, just in case.
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-08-12 3:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-12 1:06 suspect code in drivers/char/agp/generic.c Jeremy Fitzhardinge
2005-08-12 3:28 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox