From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5686C7112B for ; Mon, 15 Oct 2018 04:01:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2E0D20881 for ; Mon, 15 Oct 2018 04:01:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2E0D20881 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ellerman.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726765AbeJOLob (ORCPT ); Mon, 15 Oct 2018 07:44:31 -0400 Received: from ozlabs.org ([203.11.71.1]:50265 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726584AbeJOLoa (ORCPT ); Mon, 15 Oct 2018 07:44:30 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 42YPr06vs2z9sjF; Mon, 15 Oct 2018 15:01:04 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 719736e1cc12b2fc28eba2122893a449eee66d08 In-Reply-To: <20181009153948eucas1p14ad8b13d2482dbb9449888d544ddee15~b_uvNkTH03130331303eucas1p1E@eucas1p1.samsung.com> To: Bartlomiej Zolnierkiewicz , Benjamin Herrenschmidt , Paul Mackerras From: Michael Ellerman Cc: Arnd Bergmann , Geoff Levand , Alistair Popple , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: powerpc: remove redundant 'default n' from Kconfig-s Message-Id: <42YPr06vs2z9sjF@ozlabs.org> Date: Mon, 15 Oct 2018 15:01:04 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-10-09 at 15:39:46 UTC, Bartlomiej Zolnierkiewicz wrote: > 'default n' is the default value for any bool or tristate Kconfig > setting so there is no need to write it explicitly. > > Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO > is not set' for visible symbols") the Kconfig behavior is the same > regardless of 'default n' being present or not: > > ... > One side effect of (and the main motivation for) this change is making > the following two definitions behave exactly the same: > > config FOO > bool > > config FOO > bool > default n > > With this change, neither of these will generate a > '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied). > That might make it clearer to people that a bare 'default n' is > redundant. > ... > > Signed-off-by: Bartlomiej Zolnierkiewicz Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/719736e1cc12b2fc28eba2122893a4 cheers