Re: [PATCH 2/5] hwmon: (hp-wmi-sensors) Check if WMI event data exists

Ilpo Järvinen
2024-08-27T08:20:52Z

On Thu, 22 Aug 2024, Armin Wolf wrote:

> The BIOS can choose to return no event data in response to a
> WMI event, so the ACPI object passed to the WMI notify handler
> can be NULL.
>
> Check for such a situation and ignore the event in such a case.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> drivers/hwmon/hp-wmi-sensors.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/hwmon/hp-wmi-sensors.c b/drivers/hwmon/hp-wmi-sensors.c
> index 6892518d537c..d6bdad26feb1 100644
> --- a/drivers/hwmon/hp-wmi-sensors.c
> +++ b/drivers/hwmon/hp-wmi-sensors.c
> @@ -1628,6 +1628,9 @@ static void hp_wmi_notify(union acpi_object *wobj, void *context)
> * HPBIOS_BIOSEvent instance.
> */
>
> + if (!wobj)
> + return;
> +

I'm left to wonder why is this patch is not placed first? Can't this
happen regardless who gets the wobj? And in that case, should this have
a Fixes tag?

--
i.