From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Daniel Wagner <dwagner@suse.de>, Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/rtla: Explicitly list libtraceevent dependency
Date: Tue, 10 Jan 2023 14:55:03 +0100 [thread overview]
Message-ID: <42d1e999-79a6-94dc-cc88-77520ddce068@kernel.org> (raw)
In-Reply-To: <20230110131805.16242-1-dwagner@suse.de>
On 1/10/23 14:18, Daniel Wagner wrote:
> The current libtracefs.pkg file lists the dependency on
> libtraceevent ("pkg-config --libs libtracefs" -> "-ltracefs
> -ltraceevent").
>
> Dan Nicholson's Guide to pkg-config[1] stats that "Libs: The link
> flags specific to this package and any required libraries that don't
> support pkg-config". Thus the current libtracefs.pkg is not correct.
>
> rtla is depending on libtraceevent but it doesn't express this in
> 'pkg-config' part to retrieve the correct build flags.
>
> In order to be able to update the "Libs:" section in the libtracefs
> project we need to list the dependency explicitly to avoid future linker
> failures.
I am ok with it. Steve?
-- Daniel
next prev parent reply other threads:[~2023-01-10 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 13:18 [PATCH] tools/rtla: Explicitly list libtraceevent dependency Daniel Wagner
2023-01-10 13:55 ` Daniel Bristot de Oliveira [this message]
2023-01-10 14:08 ` Daniel Wagner
2023-01-10 14:19 ` Daniel Bristot de Oliveira
2023-01-10 14:45 ` Daniel Wagner
2023-01-10 14:51 ` Steven Rostedt
2023-01-10 14:53 ` Steven Rostedt
2023-01-10 15:08 ` Daniel Wagner
2023-01-10 14:48 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42d1e999-79a6-94dc-cc88-77520ddce068@kernel.org \
--to=bristot@kernel.org \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox