From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757362AbdJKPaJ (ORCPT ); Wed, 11 Oct 2017 11:30:09 -0400 Received: from mail-cys01nam02on0077.outbound.protection.outlook.com ([104.47.37.77]:32640 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757030AbdJKPaF (ORCPT ); Wed, 11 Oct 2017 11:30:05 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com Subject: Re: [PATCH] KVM: SVM: limit kvm_handle_page_fault to #PF handling To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1507625383-23795-1-git-send-email-pbonzini@redhat.com> From: Brijesh Singh Message-ID: <42e37c49-dacb-1449-635c-459f88add949@amd.com> Date: Wed, 11 Oct 2017 10:30:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1507625383-23795-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR19CA0004.namprd19.prod.outlook.com (2603:10b6:3:151::14) To DM2PR12MB0153.namprd12.prod.outlook.com (2a01:111:e400:50ce::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f0f35bbf-224b-4563-d4f9-08d510bcf178 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DM2PR12MB0153; X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0153;3:GemRColv6gEXKoTmpol0a8iDqFz+RZs9IY7pdVSYCl+pJjalghGy1/y2H81H7whfvhsiz17uUq71CeHizyn/1/1ZHw2kaIYJCKwykmnGlxnBp/nGYIUIf2K6WR5EkjzKEh3A20qWpfZ5mL5d01LKKSF4uUGRQR6XZqLkHl83vq+wFD7jm0PuF+KgZxFDIRIl+qNy0zEP+bgNFpwCkEBoE/q+2a6YJMf/3rUY6bQOSkh7qvqkIWD+QcO3her18+6w;25:/5XjG37Eb/htPZ4P7fCFNhRV/9BsJqsGgkG+Yi8AO8U6n+luYhdW/QvfnWcIsXz9dTTdJNQu/Ez7CIW5fv9BF3ABbrxw34rr/nLd7R/rl+isifi9QIYrGo48Aaz/16VSmxltV31F44x8Gi2mWew2pRRKjqWD5BTIFdBjNJzbH0yGO7AhvCLwrEhqpEV+ax+JcCjBLBF22BcRbgfgYPPCbdjehzBFXlxxDLlqa2kO8XIR7S0W0zXm0UEG1B4fdHiESZzjriNIa8SMzTx1A2yaXlMi7do1xe7zCjQ95IbnV0rBnJvuKzSPSObsgEdxTMyuewi7jfeL8HMEnIUMeUg+kA==;31:Dmm3OuOphOpooXMDCHciJDNObUrD8FXOgHFhCLMlbGQd1TNhk0+pP0EYRsDQ7T1sH0+uDvzu0IK42Hwm2RNT4mrLZM05dK2wLCbfO6rOQiTItvfY1ZS7ETBhZWyiMu1t0SAZk1mfSmdzY6zDmQSO7Mj3raujMyGobsS4GfYxbwFJeEBC2oFN6rDTLHzyDUMnZqQtZieUjyYB0g2rv0LzCDg52+FL+uQ3e3zlg+UoTxw= X-MS-TrafficTypeDiagnostic: DM2PR12MB0153: X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0153;20:QkGaXWlxkhwW6Dd6wliRpZHOEzKdNZS6Ui8wUg1iLERKII+7TGg4vXdUIsulRNzv4l+QEQ5IIaEcRFkqO/H0PTvKR13XHr0yW1AwngX9jqNrq5O3pkP9NBAWOpGIhvQHuvCy5cHHx270PBLVQ7+F37tWkAYfNPIYECjrsU0wAwnS3NiYy++Idp+8L3/HUoVTBJVCAEfuwPhsEQ9PXdk6hVh/amuOgEWpQe4jgz7Hlv4KtXP+/tOvGTXuCLxFUzkHd0tKIJuxVnYjx79CFnxuD1buu8Alshss78eGgkhmJRCozGig2hZ2W1IfBvZtpne6LvR6LKXh3M1CD7odMCKfdQ0Wdj8OyCTCCxqk035pmMpFboOCCKeOoPgMcBgQS4AbxM/hTVuodJ57rS23LOPzazpW0eMhywTgjVUmCQOK49EEhC4VZKyS00MmfHgOQC2yjErboAE3fjigRJZyciw3Wudyfa+GwVqVJ6b8LG8sqKiS/KhC46mEPtlAxuO88yQP;4:g+njQWNBCWlTY1BsGjr+uZjP+sXT61DzO8l4JfmBP+dAdIvOCkjmri6/kkSKGPnDu/QuLzCB52vRkYLrhobuCWpW1gp0dphqysU1UgdECTYPvcG/IvN9c/XCcC4rK9GUGcddyJvJRn3WqkOtcOoE3eoXdIKUYWMJMWPv/Pusf3TMZEbRc4ySrQBCEnNMxAxQWou28e+OvWKhGG0cQrbK//oAssdEwKlhxT/c1T3yWfG7aoMJ/ZNpOKWGzHm4dATE/BELyKioncIkcjLsZYvRaigVjc0YbW2w9Shhgw2JdlE= X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(20161123558100)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM2PR12MB0153;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM2PR12MB0153; X-Forefront-PRVS: 0457F11EAF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(39860400002)(346002)(189002)(199003)(24454002)(377454003)(6246003)(316002)(68736007)(31686004)(83506001)(2950100002)(2906002)(229853002)(65826007)(8676002)(230700001)(5660300001)(16576012)(4326008)(16526018)(53546010)(36756003)(23676002)(58126008)(101416001)(97736004)(53936002)(25786009)(64126003)(76176999)(105586002)(6486002)(106356001)(7736002)(65806001)(86362001)(50986999)(478600001)(66066001)(189998001)(31696002)(65956001)(54356999)(81166006)(81156014)(50466002)(8936002)(33646002)(305945005)(77096006)(3846002)(6116002)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR12MB0153;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjEyTUIwMTUzOzIzOlA0VmFMb2R4MDRvUzRaa2V5M0todFRPL3B0?= =?utf-8?B?TmdZYmV0ZHJPVkp4a2svd3g2bHlTL1l6R1BUc0ZSK0dpM0ladVJ6b3g5RTVY?= =?utf-8?B?TCtqVHZVSU9kcFZWTHJoVG9ORFFEeFBZT1JRN25ZT01PQmtBWjAwNE1QcXk5?= =?utf-8?B?M1pnS2ZON2Q4OVY1ZUpBU2puOW1nVGp1elY4MDllMGQ5SjlHMUhJaGlUUjhH?= =?utf-8?B?cnRNcXBoSHFIem5Ha0lwdFdvQ0RrQTJaZkZET0dTRXg5RWE2cXJ0bEs0T2Z5?= =?utf-8?B?dUNBcG13TkRtY3dyN0FIaVFmUzA3KytOZGFUcXpBQktUY29SSmJydElXMm1j?= =?utf-8?B?Q2VxeklrV204a2tmWnlCb3NoMndJdnVYUURDVDBxVU9TcVJCM3NiQnNwMTBI?= =?utf-8?B?eVcwYStQRUs3UmpIRjVFTlBrOEhkbDkyclFmZWhlYS9zVmZNZ1haNWxFWmFV?= =?utf-8?B?VFR0Yk8wWHpSMmI1bVg4eWNIMmhWdzJQM3dPQWVnYzlPZ1l6YTI2VzBCdzVl?= =?utf-8?B?enZuZW4vbExYMGpOS29TeWs5a2pWblhTek5wM1Qwcm5nVVlVMkpyYm1KYy9y?= =?utf-8?B?L2gxa25Yb1BnbWRGV2x1aE8wdll5VTAxUDJkYktIeTZqeDgwZForTVFaaDNE?= =?utf-8?B?dU9MYlRQeDVyYXAzcWtsRmhQQWEvZk1oNDliaGhMdXN1WnpzY2NVbEEvTGxH?= =?utf-8?B?TE5rZFdoUlYvSEMzUUJCN1lrOHNmby9MaVBwbGxGeml6cXFZUkZRbWlQbXJl?= =?utf-8?B?T2UxRGZZUWdBQldHTFRjZnpvWDhFUDlPbHBmNnoyQlNlK3NEQmZwcmZWYWsy?= =?utf-8?B?RFRNUlU2WDJUcGdRemxqbEdqZ0JzNUxrQnVEVEk5Z29TazcwTXRncFl3b1M2?= =?utf-8?B?QytINENTWHVYKzZMcndydnRJRmdTZS9SL0R2UTNaVzZ2OGg0YUdVOGc5Sk9p?= =?utf-8?B?S0EzM1hObGd4dk5sTWtUWVBkVEo5dGc0RVlSMzhHT002SE1Ha2hrbGRGK09E?= =?utf-8?B?SVBYM0RIc0hkSGplY1krWjZoTytOSElKNVlnVW91SHR5UlV4SVNzNUpFN01Y?= =?utf-8?B?VnI3MExIaURWRlJ0TlZ5Y1V1TTBMQnFtc0V1bFlZeldCK084Z29SVWNOcUxm?= =?utf-8?B?Yk1CcHZvRDQreW43b0l0bDVpTTNOTHk0V09SZEdLb0pRYjhaVXFDVzUxZG5s?= =?utf-8?B?dVJ1VjhLTlBYQ3ozMThrRitJNGRqL2ovdkJTcTNZTUxGVHIxeGN3S0ErU0lr?= =?utf-8?B?Q1dHdWJnTkFpSVZ2cUJCZjI5N0NNT0NoZWdzVGlrbFBOVkRQbmkzWlYwYnhY?= =?utf-8?B?dFRKakN6SDdJR0dnY3A5Q3hMUG9DRVE2eitGbmc3KzBqZ0pvRnhLKzMzSUJD?= =?utf-8?B?dm05alJNd3hCRHZqVWxOL1lPY05IeGRFbFNxdkVkVzZ2Z1RUelpKRHJJbFNp?= =?utf-8?B?ZENwZG1GT2w2T3RNWnJGWldReXFWY1hlem9DWlM1NnJUSTNRQ1lGZ3NLVTdu?= =?utf-8?B?Q3Y0UW52NXRsM2N5ZEdlM25GV0dudDFUMjRVd0RXcHhnRE9JZ2pnKzdlZUhB?= =?utf-8?B?bjk4VmY3akpobHlmaDRUek4yVGRDRHV4S01kWGRZazh6UENWYjdBR2xucGRa?= =?utf-8?B?SWt5YTRVczNCVXV5ZlVaRktacjd6MUcrYThaMFdrRjV2VDg5bFhKZHBxWXov?= =?utf-8?B?UFlnbEJnTlp3dURtZTJlU0VLdW1vTGRuRXNDV2djVktpZVJZNnhlK29JWSty?= =?utf-8?B?ZU5BNmZwV0R5SHVESTZhZDF6aE1LMFMzSXpLbkQxZk1mUzZ5R2ZkN0Y1ZUln?= =?utf-8?Q?8BgFOWI8avzg4?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0153;6:AOTQ0Zx4qqEreF6QNdzuhin1K9K8GYXC9A/0j/0RbGzo6oiKxcaajd6J6n1aUv93gBhOVxAmwMMkd4py6PFqnJxIXgVykUwRDVZSk++V3K/40eGUVo3zo7bJO3PWWm6xEDYretjbKKzuTgiVzmN19GsfbxKiVUJQmdiwPcPjV8ec3YAfb42q7aejyw7EjSrLVXxEAglaKrcxiJa4b9net3TrB4mAZablFSvF98Dan0xHbqbym9Onowk/yfkCm1LkhegVbcu9WHOvlAt0wiIPEmT5wU5s3hjpVaZbSns0zRqEq52BtIvtpFx4yGL2HEYPjA38cNpFUlfVIFZCG+NHbg==;5:TtaYlz5HTOdm3xAqL5uz7ZlJJIIKVOTa8uII0h3V8OCSo0mv+pXFl3wBczUfkyQH07O8JDFx6OmUdkKrE3fqaFMgqHVHOZAFMVOHvsCc47VWXUCd6CO5sJRuKDl1hY4k5Y+MKvQkU1yJ0g3+rKJoXg==;24:7PnoujpQNmC9M9KGL2Qtk246vuKIhuq9jRMGC01PsvNcwSosSsYeB5gUyB0sFlIPuvE3iCtapcmrMylLYjEjEk5VyRfVtjdLjutIoaE04G4=;7:WKjm+VGfEosSpcXV6iGCmfwnYUhNdnmXE2JaJ0WTPXQxHoBHqpw9EdvogqQETNNk5K3tle06EvUVk2H8XSSbrKkbnyMfHK7hELJDvMnINommIQwmn8BIUY2gy6XRJDZh2SFSGKFi9G9RJ6YdFrZwSVM2eMsYa6QAtdOgBHLDjNeopmiqSLqAa4AvPuDMzZFYZvnW5Uh+bQ+fVrbK3ij+0qekvjjRnjKxYZg2j4i7164= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0153;20:oCUfm7xMhPnvoZ456Q7SMI1EiBzPnePaZh5eyhiaCfibUSoCGgzTOg/KV0BtBoC7G/FIAGWJgz5Gyu73bgHOpzJkPI9+O6uV7/qy3K7JClmvHLjqyOPPzXlhB5cs+JqE3SQFwFKOxXdop1cOFY0pXmReaj3A0Lbcu759yS4DPKroNaHiDE9TyQqqwBppMj0Ubmt+T/Cx7tHidfb8MSaf91TdPC4Qua80KrM5sYFgU8hpx4A6uepC5fnP+TwV/XwL X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2017 15:30:03.2354 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0153 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paolo, On 10/10/2017 03:49 AM, Paolo Bonzini wrote: ... > + > +static int npf_interception(struct vcpu_svm *svm) > +{ > + u64 fault_address = svm->vmcb->control.exit_info_2; > + u64 error_code = svm->vmcb->control.exit_info_1; > + > + trace_kvm_page_fault(fault_address, error_code); > + return kvm_mmu_page_fault(&svm->vcpu, error_code, fault_address, ^^^^^^^ ^^^^^ The argument order need to be swapped, second argument should be 'fault_address' and third 'error_code' return kvm_mmu_page_fault(&svm->vcpu, fault_address, error_code, svm->vmcb->control.insn_bytes, svm->vmcb->control.insn_len); With that fixed. Reviewed-by: Brijesh Singh thanks