From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Renze Nicolai <renze@rnplus.nl>,
linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-aspeed@lists.ozlabs.org, arnd@arndb.de, olof@lixom.net,
soc@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au,
andrew@aj.id.au
Subject: Re: [PATCH 2/3] ARM: dts: Disable unused ADC channels for Asrock X570D4U BMC
Date: Wed, 03 Apr 2024 13:59:17 +1030 [thread overview]
Message-ID: <42e91dc2bccdcac96abd729def8a05b2612488a7.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240329130152.878944-3-renze@rnplus.nl>
Hi Renze,
On Fri, 2024-03-29 at 14:01 +0100, Renze Nicolai wrote:
> This commit disables unused ADC channels and labels the ADC channels used with their function.
Please run this through checkpatch and address the warnings.
Also, the submitting patches documentation[1] suggests using the
imperative mood - instead of "This commit disables ...", use "Disable
...". The change subject is phrased the expected way.
[1]: https://docs.kernel.org/process/submitting-patches.html
Taking the subject and the description together, the description feels
a little redundant. Maybe it could be trimmed back to
> Also, label the ADC channels used with their function.
Andrew
next prev parent reply other threads:[~2024-04-03 3:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 13:01 [PATCH 0/3] ARM: dts: Update devicetree of Asrock X570D4U BMC Renze Nicolai
2024-03-29 13:01 ` [PATCH 1/3] ARM: dts: Modify GPIO table for " Renze Nicolai
2024-04-03 3:21 ` Andrew Jeffery
2024-03-29 13:01 ` [PATCH 2/3] ARM: dts: Disable unused ADC channels " Renze Nicolai
2024-04-03 3:29 ` Andrew Jeffery [this message]
2024-03-29 13:01 ` [PATCH 3/3] ARM: dts: Modify I2C bus configuration Renze Nicolai
2024-04-03 3:30 ` Andrew Jeffery
2024-04-01 16:36 ` [PATCH 0/3] ARM: dts: Update devicetree of Asrock X570D4U BMC Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42e91dc2bccdcac96abd729def8a05b2612488a7.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=renze@rnplus.nl \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox