From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DABB22A4E1 for ; Fri, 19 Dec 2025 14:27:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154464; cv=none; b=bwlDtXb4WwVPJzrRxlS+W094PmAVn0mf+pnsOSefAJ8ok+bBm5hDLTl8K7r7byDvdnzChpRHGqRWML6H0ATdUO5uCXcPfEEmfEr5kqIk3nrKShLkH+iSRq8fMCF9Njg3ymB5i1B/71S+3pXo4OdDFMd+Yt6cjToMpY2v1IHAKko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766154464; c=relaxed/simple; bh=HO8ZZrU/bBEMOVQh8mieozRvlpMAE0On9rtZ68Hugq0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mzs0SAdwAnKrno6uUsjP+coX6RVdF2WTHxuvF0Q3kIG1VQXw/IUvBqWTkIGciqMtbSVUa8tls40ITSbh2D+rpI/tnzHmqUsH7SsB15tZooTdMexaOlPpHNTnRyQpRxF6RkyicGpbwEs1ySX/cdVizGQZXxDRhZsYkftnGKrtuF8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Q5WFdhEx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q5WFdhEx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D8EDC4CEF1; Fri, 19 Dec 2025 14:27:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766154463; bh=HO8ZZrU/bBEMOVQh8mieozRvlpMAE0On9rtZ68Hugq0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Q5WFdhExfBN9+w6ZhOy/eDhnHGelaM6ci4QqnKF0dgSS2B9sLx7dag6g6TztbKTok hz90mA8VWZMrSJkCvW/6ACAoH7yRUw3uL9VcYAwrLbDeWC8Kcd5lmON1wjbDarz4l+ q1kv6CZoNUnwr7v0VyL8SoTPco/SYTAGDKFmn673ABFqxeW//+nz62Ia8qFl2XLcnE sgpO5vHR4FOlyP6b/VjVzrJ/hgYcOuxbO0E/LuAVkHGGG3o0R+r/5vprz0JPuTQnCn v1AHFdDlkKJZAA7Ryj8/qb59XjZTEl26vePlSmI2I0mtd5EQVKrrj6BgyLL5hGVO2o mIh6kv32Z2Kvg== Message-ID: <42ef695f-030d-4e18-befd-bc774815c552@kernel.org> Date: Fri, 19 Dec 2025 15:27:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/gup: remove no longer used gup_fast_undo_dev_pagemap To: Kairui Song , linux-mm@kvack.org Cc: Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Alistair Popple , linux-kernel@vger.kernel.org, Kairui Song References: <20251219-gup-cleanup-v1-1-348a70d9eecb@tencent.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <20251219-gup-cleanup-v1-1-348a70d9eecb@tencent.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/19/25 12:46, Kairui Song wrote: > From: Kairui Song > > This helper is no longer used after commit fd2825b0760a ("mm/gup: remove > pXX_devmap usage from get_user_pages()"). > > Signed-off-by: Kairui Song > --- > mm/gup.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 95d948c8e86c..8e7dc2c6ee73 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2806,17 +2806,6 @@ static bool gup_fast_folio_allowed(struct folio *folio, unsigned int flags) > return !reject_file_backed || shmem_mapping(mapping); > } > > -static void __maybe_unused gup_fast_undo_dev_pagemap(int *nr, int nr_start, > - unsigned int flags, struct page **pages) > -{ > - while ((*nr) - nr_start) { > - struct folio *folio = page_folio(pages[--(*nr)]); > - > - folio_clear_referenced(folio); > - gup_put_folio(folio, 1, flags); > - } > -} > - Thanks! Acked-by: David Hildenbrand (Red Hat) -- Cheers David