* [PATCH] [TRIVIAL] relayfs: remove comment on overwrite mode
@ 2005-08-15 4:34 Hareesh Nagarajan
2005-08-15 14:58 ` Tom Zanussi
0 siblings, 1 reply; 2+ messages in thread
From: Hareesh Nagarajan @ 2005-08-15 4:34 UTC (permalink / raw)
To: Andrew Morton; +Cc: Tom Zanussi, linux-kernel, karim
[-- Attachment #1: Type: text/plain, Size: 200 bytes --]
Hi Andrew,
The overwrite arg has been removed from the relay_subbufs_consumed()
(since it has been removed from relayfs altogether) so the comment
preceding the function must go.
Thanks,
Hareesh
[-- Attachment #2: relayfs-remove-overwrite-comment.patch --]
[-- Type: text/plain, Size: 563 bytes --]
diff -ruN linux-akpm/fs/relayfs/relay.c linux/fs/relayfs/relay.c
--- linux-akpm/fs/relayfs/relay.c 2005-08-14 21:16:35.000000000 -0700
+++ linux/fs/relayfs/relay.c 2005-08-14 21:26:10.000000000 -0700
@@ -342,9 +342,6 @@
* Adds to the channel buffer's consumed sub-buffer count.
* subbufs_consumed should be the number of sub-buffers newly consumed,
* not the total consumed.
- *
- * NOTE: kernel clients don't need to call this function if the channel
- * mode is 'overwrite'.
*/
void relay_subbufs_consumed(struct rchan *chan,
unsigned int cpu,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [TRIVIAL] relayfs: remove comment on overwrite mode
2005-08-15 4:34 [PATCH] [TRIVIAL] relayfs: remove comment on overwrite mode Hareesh Nagarajan
@ 2005-08-15 14:58 ` Tom Zanussi
0 siblings, 0 replies; 2+ messages in thread
From: Tom Zanussi @ 2005-08-15 14:58 UTC (permalink / raw)
To: Hareesh Nagarajan; +Cc: Andrew Morton, Tom Zanussi, linux-kernel, karim
Hareesh Nagarajan writes:
> Hi Andrew,
>
> The overwrite arg has been removed from the relay_subbufs_consumed()
> (since it has been removed from relayfs altogether) so the comment
> preceding the function must go.
relayfs still supports overwrite mode, but it's now implemented
differently (via the subbuf_start() callback instead of an overwrite
arg), so this comment is still valid.
Tom
>
> Thanks,
>
> Hareesh
> diff -ruN linux-akpm/fs/relayfs/relay.c linux/fs/relayfs/relay.c
> --- linux-akpm/fs/relayfs/relay.c 2005-08-14 21:16:35.000000000 -0700
> +++ linux/fs/relayfs/relay.c 2005-08-14 21:26:10.000000000 -0700
> @@ -342,9 +342,6 @@
> * Adds to the channel buffer's consumed sub-buffer count.
> * subbufs_consumed should be the number of sub-buffers newly consumed,
> * not the total consumed.
> - *
> - * NOTE: kernel clients don't need to call this function if the channel
> - * mode is 'overwrite'.
> */
> void relay_subbufs_consumed(struct rchan *chan,
> unsigned int cpu,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-08-15 14:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-08-15 4:34 [PATCH] [TRIVIAL] relayfs: remove comment on overwrite mode Hareesh Nagarajan
2005-08-15 14:58 ` Tom Zanussi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox