From: Valdis.Kletnieks@vt.edu
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator
Date: Thu, 23 Jun 2011 10:19:05 -0400 [thread overview]
Message-ID: <43010.1308838745@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Thu, 23 Jun 2011 10:15:51 +0800." <1308795351.15248.2.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
On Thu, 23 Jun 2011 10:15:51 +0800, Axel Lin said:
> Base on Mark's comment [1], I make the Kconfig entry invisible to users.
> +config TPS65911_COMPARATOR
> + tristate
> +
This can't possibly be right by itself- how would it ever get enabled, without
a SELECT pointing at it or a user selecting it?
Is there a follow-on patch that adds a user?
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2011-06-23 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 2:15 [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator Axel Lin
2011-06-23 2:17 ` [PATCH 2/3] mfd: Fix build error for tps65911-comparator.c Axel Lin
2011-06-23 2:19 ` [PATCH 3/3] mfd: Remove comp1_threshold and comp2_threshold sysfs entries in tps65911_comparator_remove Axel Lin
2011-06-23 14:19 ` Valdis.Kletnieks [this message]
2011-06-27 3:26 ` [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator Axel Lin
2011-07-04 15:14 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43010.1308838745@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jedu@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox