From: Mika Kukkonen <mikukkon@gmail.com>
To: len.brown@intel.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Build failure with !CONFIG_PCI and with CONFIG_ISAPNP=y && CONFIG_PNPBIOS=y
Date: Mon, 14 Feb 2005 15:23:06 +0200 [thread overview]
Message-ID: <4301cff605021405234a44b8d4@mail.gmail.com> (raw)
Trying to build latest kernel with !CONFIG_PCI and with
CONFIG_ISAPNP=y && CONFIG_PNPBIOS=y
I got the following build error:
LD vmlinux
drivers/built-in.o(.text+0x5486): In function
'pnpbios_parse_allocated_irqresource':
: undefined reference to 'pcibios_penalize_isa_irq'
Clearly pcibios_penalize_isa_irq() is meant to be called only with
CONFIG_PCI, so
following patch suggests itself:
--- linux-2.5/drivers/pnp/pnpbios/rsparser.c 2005-02-14 12:08:49.000000000 +0200
+++ linux-tiny/drivers/pnp/pnpbios/rsparser.c 2005-02-14
12:12:32.000000000 +0200
@@ -7,7 +7,12 @@
#include <linux/ctype.h>
#include <linux/pnp.h>
#include <linux/pnpbios.h>
+
+#ifdef CONFIG_PCI
#include <linux/pci.h>
+#else
+inline void pcibios_penalize_isa_irq(int irq) {}
+#endif /* CONFIG_PCI */
#include "pnpbios.h"
By the way, while using cscope I noticed that there is very bogus looking
definition of pcibios_penalize_isa_irq() in line 24 of arch/i386/pci/visws.c,
but as that is not called anywhere in that file it could be simply removed.
No patch for that though because I could not get the file to compile.
--MiKu
reply other threads:[~2005-02-14 13:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4301cff605021405234a44b8d4@mail.gmail.com \
--to=mikukkon@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox