public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Build failure with !CONFIG_PCI and with CONFIG_ISAPNP=y && CONFIG_PNPBIOS=y
@ 2005-02-14 13:23 Mika Kukkonen
  0 siblings, 0 replies; only message in thread
From: Mika Kukkonen @ 2005-02-14 13:23 UTC (permalink / raw)
  To: len.brown; +Cc: linux-kernel

Trying to build latest kernel with !CONFIG_PCI and with
CONFIG_ISAPNP=y && CONFIG_PNPBIOS=y
I got the following build error:

  LD	vmlinux
drivers/built-in.o(.text+0x5486): In function
'pnpbios_parse_allocated_irqresource':
: undefined reference to 'pcibios_penalize_isa_irq'

Clearly pcibios_penalize_isa_irq() is meant to be called only with
CONFIG_PCI, so
following patch suggests itself:

--- linux-2.5/drivers/pnp/pnpbios/rsparser.c	2005-02-14 12:08:49.000000000 +0200
+++ linux-tiny/drivers/pnp/pnpbios/rsparser.c	2005-02-14
12:12:32.000000000 +0200
@@ -7,7 +7,12 @@
 #include <linux/ctype.h>
 #include <linux/pnp.h>
 #include <linux/pnpbios.h>
+
+#ifdef CONFIG_PCI
 #include <linux/pci.h>
+#else
+inline void pcibios_penalize_isa_irq(int irq) {}
+#endif /* CONFIG_PCI */

 #include "pnpbios.h"

By the way, while using cscope I noticed that there is very bogus looking
definition of pcibios_penalize_isa_irq() in line 24 of arch/i386/pci/visws.c,
but as that is not called anywhere in that file it could be simply removed.
No patch for that though because I could not get the file to compile.

--MiKu

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-02-14 13:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-14 13:23 [PATCH] Build failure with !CONFIG_PCI and with CONFIG_ISAPNP=y && CONFIG_PNPBIOS=y Mika Kukkonen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox