From: Mika Kukkonen <mikukkon@iki.fi>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix allnoconfig build with gcc4
Date: Sun, 11 Sep 2005 20:23:37 +0300 [thread overview]
Message-ID: <4301cff60509111023787cdaf1@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0509101356320.30958@g5.osdl.org>
On 9/11/05, Linus Torvalds <torvalds@osdl.org> wrote:
>
>
(...)
> No, this would cause a compile error if CONFIG_NET and CONFIG_SYSCTL
> is enabled (because sysctl_net.c needs that declaration).
Ah yes. I got confused by googling which showed that there are some issues
with these declarations and gcc4 (see for example this thread:
http://gcc.gnu.org/ml/gcc/2005-02/msg00053.html).
> So the correct solution is apparently either one of
>
> - always declare an empty "struct ctl_table" regardless of whether SYSCTL
> is enabled or not.
>
> This might be a good idea, since it probably allows more code to be
> compiled without checking for CONFIG_SYSCTL.
>
> - put the ether_table[] declaration inside a #ifdef CONFIG_SYSCTL.
core_table in include/net/sock.h uses the latter option, so I'll send
you a patch
for that (with better email client).
--MiKu
prev parent reply other threads:[~2005-09-11 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-10 20:19 [PATCH] Fix allnoconfig build with gcc4 mikukkon
2005-09-10 21:00 ` Linus Torvalds
2005-09-11 17:23 ` Mika Kukkonen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4301cff60509111023787cdaf1@mail.gmail.com \
--to=mikukkon@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox