From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>,
sakari.ailus@linux.intel.com, krzk+dt@kernel.org,
kieran.bingham@ideasonboard.com
Cc: dave.stevenson@raspberrypi.com, pratap.nirujogi@amd.com,
laurent.pinchart@ideasonboard.com,
tarang.raval@siliconsignals.io,
"Himanshu Bhavani" <himanshu.bhavani@siliconsignals.io>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Ricardo Ribalda" <ribalda@chromium.org>,
"André Apitzsch" <git@apitzsch.eu>,
"Arnd Bergmann" <arnd@arndb.de>,
"Dongcheng Yan" <dongcheng.yan@intel.com>,
"Jingjing Xiong" <jingjing.xiong@intel.com>,
"Matthias Fend" <matthias.fend@emfend.at>,
"Benjamin Mugnier" <benjamin.mugnier@foss.st.com>,
"Sylvain Petinot" <sylvain.petinot@foss.st.com>,
"Heimir Thor Sverrisson" <heimir.sverrisson@gmail.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Hans de Goede" <hansg@kernel.org>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add ov2735 sensor
Date: Thu, 10 Jul 2025 15:35:51 +0200 [thread overview]
Message-ID: <43023f6f-2a02-4c5c-8f45-66ff7df1e8ad@kernel.org> (raw)
In-Reply-To: <20250710131107.69017-2-hardevsinh.palaniya@siliconsignals.io>
On 10/07/2025 15:10, Hardevsinh Palaniya wrote:
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - avdd-supply
> + - dovdd-supply
> + - dvdd-supply
> + - port
Now I looked at your driver and the code clearly says that GPIOs are
not optional.
You really need to sync the binding in the driver. They cannot define
completely different ABI.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-10 13:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 13:10 [PATCH v3 0/2] media: i2c: Add ov2735 camera sensor driver Hardevsinh Palaniya
2025-07-10 13:10 ` [PATCH v3 1/2] dt-bindings: media: i2c: Add ov2735 sensor Hardevsinh Palaniya
2025-07-10 13:33 ` Krzysztof Kozlowski
2025-07-10 13:35 ` Krzysztof Kozlowski [this message]
2025-07-10 21:05 ` Laurent Pinchart
2025-07-10 18:33 ` Rob Herring
2025-07-10 21:08 ` Laurent Pinchart
2025-07-10 13:10 ` [PATCH v3 2/2] media: i2c: add ov2735 image sensor driver Hardevsinh Palaniya
2025-07-10 13:46 ` Andy Shevchenko
2025-07-10 21:21 ` Laurent Pinchart
2025-07-11 7:56 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43023f6f-2a02-4c5c-8f45-66ff7df1e8ad@kernel.org \
--to=krzk@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=benjamin.mugnier@foss.st.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dongcheng.yan@intel.com \
--cc=git@apitzsch.eu \
--cc=hansg@kernel.org \
--cc=hardevsinh.palaniya@siliconsignals.io \
--cc=heimir.sverrisson@gmail.com \
--cc=himanshu.bhavani@siliconsignals.io \
--cc=hverkuil@xs4all.nl \
--cc=jingjing.xiong@intel.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matthias.fend@emfend.at \
--cc=mchehab@kernel.org \
--cc=pratap.nirujogi@amd.com \
--cc=ribalda@chromium.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
--cc=tarang.raval@siliconsignals.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox