From: Krzysztof Kozlowski <krzk@kernel.org>
To: "tian.ge" <tian.ge@silergymicro.com>,
sre@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, lei.zhang@silergycorp.com,
frank.fan@silergymicro.com
Subject: Re: [PATCH] dt-bindings: power: supply: Add Silergy SY6974B charger
Date: Tue, 16 Dec 2025 06:33:25 +0100 [thread overview]
Message-ID: <43033462-bdea-48b2-9108-acc29b60e82e@kernel.org> (raw)
In-Reply-To: <20251216021851.654957-1-tian.ge@silergymicro.com>
On 16/12/2025 03:18, tian.ge wrote:
> Add bindings for the Silergy SY6974B I2C controlled charger.
Why? Where is any user of this?
Plus this was not tested, so I finish review here. You did not follow
basic DT binding rules, please read first writing-bindings doc or my
DTS101 talk.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-16 5:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 2:18 [PATCH] dt-bindings: power: supply: Add Silergy SY6974B charger tian.ge
2025-12-16 3:41 ` Rob Herring (Arm)
2025-12-16 5:33 ` Krzysztof Kozlowski [this message]
2025-12-17 9:30 ` tian.ge
2025-12-17 9:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43033462-bdea-48b2-9108-acc29b60e82e@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank.fan@silergymicro.com \
--cc=krzk+dt@kernel.org \
--cc=lei.zhang@silergycorp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tian.ge@silergymicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox