From: Ollie Wild <aaw@rincewind.tv>
To: Patrick McHardy <kaber@trash.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix dst_entry leak in icmp_push_reply()
Date: Wed, 17 Aug 2005 23:41:24 -0700 [thread overview]
Message-ID: <43042D94.4030303@rincewind.tv> (raw)
In-Reply-To: <4303CEC5.3010502@trash.net>
Patrick McHardy wrote:
> Ollie Wild wrote:
>
>> If the ip_append_data() call in icmp_push_reply() fails,
>> ip_flush_pending_frames() needs to be called. Otherwise, ip_rt_put()
>> is never called on inet_sk(icmp_socket->sk)->cork.rt, which prevents
>> the route (and net_device) from ever being freed.
>
>
> Your patch doesn't fit your description, the else-condition you're
> adding triggers when the queue is empty, so what is the point?
Since we're only calling ip_append_data() once here, the two conditions
are identical.
Ollie
next prev parent reply other threads:[~2005-08-18 6:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-17 20:21 [PATCH] fix dst_entry leak in icmp_push_reply() Ollie Wild
2005-08-17 23:56 ` Patrick McHardy
2005-08-18 6:41 ` Ollie Wild [this message]
2005-08-18 18:42 ` Patrick McHardy
2005-08-18 18:45 ` Ollie Wild
2005-08-18 18:59 ` Patrick McHardy
2005-08-18 19:05 ` Ollie Wild
2005-08-18 21:32 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43042D94.4030303@rincewind.tv \
--to=aaw@rincewind.tv \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox