[PATCH] pull XFS support out of Kconfig submenu

[PATCH] pull XFS support out of Kconfig submenu

[Jesper Juhl]

It seems slightly odd to me that XFS support should be in a separate submenu,
when all the other filesystems are not using submenus but are directly 
selectable from the Filesystems menu.
This patch makes XFS Kconfig entries behave like everything else.

Ignore if there's a good reason for the menu, please consider applying 
otherwise.

Please Cc: me on replies.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 fs/xfs/Kconfig |    5 +----
 1 files changed, 1 insertion(+), 4 deletions(-)

--- linux-2.6.13-rc6-git9-orig/fs/xfs/Kconfig	2005-06-17 21:48:29.000000000 +0200
+++ linux-2.6.13-rc6-git9/fs/xfs/Kconfig	2005-08-17 22:38:26.000000000 +0200
@@ -1,5 +1,3 @@
-menu "XFS support"
-
 config XFS_FS
 	tristate "XFS filesystem support"
 	select EXPORTFS if NFSD!=n
@@ -22,6 +20,7 @@
 
 config XFS_EXPORT
 	bool
+	depends on XFS_FS
 	default y if XFS_FS && EXPORTFS
 
 config XFS_RT
@@ -81,5 +80,3 @@
 	  Linux website <http://acl.bestbits.at/>.
 
 	  If you don't know what Access Control Lists are, say N.
-
-endmenu

Re: [PATCH] pull XFS support out of Kconfig submenu

[Chris Wedgwood]

On Wed, Aug 17, 2005 at 10:45:48PM +0200, Jesper Juhl wrote:

> It seems slightly odd to me that XFS support should be in a separate
> submenu, when all the other filesystems are not using submenus but
> are directly selectable from the Filesystems menu.

XFS also has an out-of-tree version.  Making it a submenu is probably
to make maintenance easier (ie. replace files, not merge).

Re: [xfs-masters] Re: [PATCH] pull XFS support out of Kconfig submenu

[Russell Cattelan]

On Thu, 2005-08-18 at 06:53 -0700, Chris Wedgwood wrote:
> On Wed, Aug 17, 2005 at 10:45:48PM +0200, Jesper Juhl wrote:
> 
> > It seems slightly odd to me that XFS support should be in a separate
> > submenu, when all the other filesystems are not using submenus but
> > are directly selectable from the Filesystems menu.
> 
> XFS also has an out-of-tree version.  Making it a submenu is probably
> to make maintenance easier (ie. replace files, not merge).
> 
That is why the Kconfig options for xfs moved from fs/Kconfig to
fs/xfs/Kconfig but using submenu was simply a convince thing 
to group all the XFS options together.

If the submenu is really causing people distress go ahead and 
remove it. Since it's a cosmetic change it's not going to impact
anything.

-Russell

Re: [xfs-masters] Re: [PATCH] pull XFS support out of Kconfig submenu

[Eric Sandeen]

Chris Wedgwood wrote:
> On Wed, Aug 17, 2005 at 10:45:48PM +0200, Jesper Juhl wrote:
> 
> 
>>It seems slightly odd to me that XFS support should be in a separate
>>submenu, when all the other filesystems are not using submenus but
>>are directly selectable from the Filesystems menu.
> 
> 
> XFS also has an out-of-tree version.  Making it a submenu is probably
> to make maintenance easier (ie. replace files, not merge).
> 

Where the Kconfig is vs. where the menu appears are 2 different things 
though.  The latest kernel has our own Kconfig in fs/xfs, and fs/Kconfig 
just does:

source "fs/xfs/Kconfig"

This does facilitate swapping in a devel version of fs/xfs via a 
symlink, etc.

However, fs/xfs/Kconfig does still start with

menu "XFS support"

which puts it in a submenu, unlike every other fs.

I have no problem with removing the submenu.

-Eric

Re: [xfs-masters] Re: [PATCH] pull XFS support out of Kconfig submenu

[Eric Sandeen]

Eric Sandeen wrote:
> I have no problem with removing the submenu.

Hm, however, if this is a purely cosmetic thing, let's go all the way 
and format the xfs options like the others, with indentation etc:

  config XFS_RT
-       bool "Realtime support (EXPERIMENTAL)"
+       bool "  XFS Realtime support (EXPERIMENTAL)"


May be simpler to just make this change internally & let Nathan push it 
out.  I do agree that it looks better.  :)

-Eric

Re: [xfs-masters] Re: [PATCH] pull XFS support out of Kconfig submenu

[Nathan Scott]

On Thu, Aug 18, 2005 at 10:22:26AM -0500, Russell Cattelan wrote:
> .. fs/xfs/Kconfig but using submenu was simply a convince thing 
> to group all the XFS options together.

s/convince/convenience/

> If the submenu is really causing people distress go ahead and 
> remove it. Since it's a cosmetic change it's not going to impact
> anything.

Yep, I guess we should just queue this up for 2.6.14.

cheers.

-- 
Nathan