Re: [PATCH] fix dst_entry leak in icmp_push_reply()

Ollie Wild
2005-08-18T06:41:31Z

Patrick McHardy wrote:

> Ollie Wild wrote:
>
>> If the ip_append_data() call in icmp_push_reply() fails,
>> ip_flush_pending_frames() needs to be called. Otherwise, ip_rt_put()
>> is never called on inet_sk(icmp_socket->sk)->cork.rt, which prevents
>> the route (and net_device) from ever being freed.
>
>
> Your patch doesn't fit your description, the else-condition you're
> adding triggers when the queue is empty, so what is the point?

Since we're only calling ip_append_data() once here, the two conditions
are identical.

Ollie