public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Pavel Machek <pavel@ucw.cz>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: Multi-sector writes
Date: Fri, 19 Aug 2005 10:12:05 +0200	[thread overview]
Message-ID: <43059455.4060505@drzeus.cx> (raw)
In-Reply-To: <20050819075808.GB1825@elf.ucw.cz>

Pavel Machek wrote:

>
>Maybe the card is pretty close to going to crash, but... two disk
>successive disk errors still should not be cause for journal
>corruption.
>
>[Also errors could be corelated. Imagine severe overheat. You'll
>successive failing writes, but if you let cool it down, you'll still
>have working media... only with corrupt journal :-)]
>								Pavel
>  
>

Hmm... So how is this handled in other systems? E.g. if you yank a USB
device whilst there is a lot of outstanding data inside the device that
hasn't been ack:d yet.

The way I see it, filesystems should assume the following at a failed write:

* 0-n sectors were written successfully.
* 0-1 sectors have corrupt data.
* 0-m sectors have old data.
* The lower layer will report back 0-k successfully written sectors,
where k <= n.

So perhaps the best course of action is to remove the sector-by-sector
failsafe? It will increase the chance of k < n, but it will not break
above assumption.

Rgds
Pierre


  reply	other threads:[~2005-08-19  8:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-14 12:41 [PATCH] mmc: Multi-sector writes Pierre Ossman
2005-08-17 22:56 ` Andrew Morton
2005-08-18  5:48   ` Pierre Ossman
2005-08-18  5:48     ` Andrew Morton
2005-08-18  6:38       ` Russell King
2005-08-18  7:26         ` Pierre Ossman
2005-08-18  8:23           ` Russell King
2005-08-18  8:48             ` Pierre Ossman
2005-08-18 20:19               ` Pavel Machek
2005-08-19  5:00                 ` Pierre Ossman
2005-08-19  7:58                   ` Pavel Machek
2005-08-19  8:12                     ` Pierre Ossman [this message]
2005-08-18  9:42           ` Alan Cox
2005-08-18  9:33             ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43059455.4060505@drzeus.cx \
    --to=drzeus-list@drzeus.cx \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox