From: Joel Schopp <jschopp@austin.ibm.com>
To: boutcher@cs.umn.edu, Andrew Morton <akpm@osdl.org>
Cc: linux-scsi@vger.kernel.org, linuxppc64-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch] ibmvscsi timeout fix
Date: Mon, 22 Aug 2005 14:53:23 -0500 [thread overview]
Message-ID: <430A2D33.2000308@austin.ibm.com> (raw)
In-Reply-To: <20050822193826.GA2455@cs.umn.edu>
> This patch fixes a long term borkenness in
> ibmvscsi where we were using the wrong timeout
> field from the scsi command (and using the
> wrong units.) Now broken by the fact that the
> scsi_cmnd timeout field is gone entirely.
> This only worked before because all the SCSI
> targets assumed that 0 was default.
That was fast. I report the error to you and get a patch next time I
look at my mail. This does fix the build break I saw in a
2.6.13-rc6-mm1 defconfig on ppc64.
Adding Andrew Morton to the distribution list since somebody else is
bound to notice that ppc64 -mm doesn't compile anymore.
Acked-by: Joel Schopp <jschopp@austin.ibm.com>
>
> Signed-off-by: Dave Boutcher <boutcher@us.ibm.com>
>
> --- linux-2.6.13-rc6-mm1-orig/drivers/scsi/ibmvscsi/ibmvscsi.c 2005-08-22 13:54:20.111955197 -0500
> +++ linux-2.6.13-rc6-mm1/drivers/scsi/ibmvscsi/ibmvscsi.c 2005-08-22 14:22:56.265042174 -0500
> @@ -594,7 +594,7 @@
> init_event_struct(evt_struct,
> handle_cmd_rsp,
> VIOSRP_SRP_FORMAT,
> - cmnd->timeout);
> + cmnd->timeout_per_command/HZ);
>
> evt_struct->cmnd = cmnd;
> evt_struct->cmnd_done = done;
>
>
parent reply other threads:[~2005-08-22 19:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20050822193826.GA2455@cs.umn.edu>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430A2D33.2000308@austin.ibm.com \
--to=jschopp@austin.ibm.com \
--cc=akpm@osdl.org \
--cc=boutcher@cs.umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox