public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ted Unangst <tedu@coverity.com>
To: linux-kernel@vger.kernel.org
Subject: some missing spin_unlocks
Date: Mon, 22 Aug 2005 15:26:47 -0700	[thread overview]
Message-ID: <430A5127.5000304@coverity.com> (raw)

I think these are all real bugs.

sound/synth/emux/emux_synth.c snd_emux_note_on, line 101
snd_assert will return without unlocking emu->voice_lock (line 89)

sound/pci/au88x0/au88x0_core.c vortex_adb_allocroute, search for EBUSY
returns without unlocking vortex->lock

net/rose/rose_route.c rose_route_frame, line 998
returns without unlocking rose_node_list_lock, rose_neigh_list_lock, or 
rose_route_list_lock

net/rose/rose_timer.c rose_heartbeat_expiry, line 141
rose_destroy_socket does not unlock sk as far as i can see

drivers/net/irda/donauboe.c toshoboe_net_ioctl, search for EPERM
returns without unlocking self->lock


-- 
Ted Unangst             www.coverity.com             Coverity, Inc.

             reply	other threads:[~2005-08-22 22:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-22 22:26 Ted Unangst [this message]
2005-08-23 16:46 ` some missing spin_unlocks David S. Miller
2005-08-23 16:54   ` Arjan van de Ven
2005-08-23 17:30     ` David S. Miller
2005-08-23 17:40       ` Arjan van de Ven
2005-08-23 17:46         ` David S. Miller
2005-08-24 15:56 ` Lee Revell
2005-08-24 17:01   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=430A5127.5000304@coverity.com \
    --to=tedu@coverity.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox