From: Nick Sillik <n.sillik@temple.edu>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [-mm PATCH] drivers/char/speakup/synthlist.h - Fix warnings with -Wundef
Date: Wed, 24 Aug 2005 01:38:56 -0400 [thread overview]
Message-ID: <430C07F0.8010001@temple.edu> (raw)
In-Reply-To: <20050824053703.GA23807@mipter.zuzino.mipt.ru>
Alexey Dobriyan wrote:
>
>>-#define CFG_TEST(name) (name)
>>+#define CFG_TEST(name) defined(name)
>
>
> No. Just remove this obfuscating macro.
Agreed, here is the fixed patch
Signed-Off-By: Nick Sillik <n.sillik@temple.edu>
next prev parent reply other threads:[~2005-08-24 5:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-23 20:00 [-mm PATCH] drivers/char/speakup/synthlist.h - Fix warnings with -Wundef Nick Sillik
2005-08-24 5:37 ` Alexey Dobriyan
2005-08-24 5:38 ` Nick Sillik [this message]
2005-08-24 5:52 ` Nick Sillik
2005-08-24 18:04 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430C07F0.8010001@temple.edu \
--to=n.sillik@temple.edu \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox