From: Eric Dumazet <dada1@cosmosbay.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] removes filp_count_lock and changes nr_files type to atomic_t
Date: Thu, 25 Aug 2005 11:17:23 +0200 [thread overview]
Message-ID: <430D8CA3.3030709@cosmosbay.com> (raw)
In-Reply-To: <20050825090854.GA9740@infradead.org>
Christoph Hellwig a écrit :
> On Thu, Aug 25, 2005 at 10:45:12AM +0200, Eric Dumazet wrote:
>
>>This patch assumes that atomic_read() is a plain {return v->counter;} on
>>all architectures. (keywords : sysctl, /proc/sys/fs/file-nr, proc_dointvec)
>
>
> But that's not true. You need to write you own sysctl handler for it,
> probably worth adding a generic atomic_t sysctl handler while you're
> at it.
>
I checked linux-2.6.13-rc7 tree, and atomic_read() is just a wrapper to read
v->counter.
In the ancient times, yes, atomic_read() was different on some archs, but not
today.
Eric
next prev parent reply other threads:[~2005-08-25 9:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-24 21:46 [patch] Additions to .data.read_mostly section Ravikiran G Thirumalai
2005-08-24 22:38 ` Eric Dumazet
2005-08-25 7:56 ` Arjan van de Ven
2005-08-25 8:45 ` [PATCH] removes filp_count_lock and changes nr_files type to atomic_t Eric Dumazet
2005-08-25 9:05 ` Arjan van de Ven
2005-08-25 9:20 ` Eric Dumazet
2005-08-25 9:31 ` Arjan van de Ven
2005-08-25 9:08 ` Christoph Hellwig
2005-08-25 9:17 ` Eric Dumazet [this message]
2005-08-25 9:23 ` Christoph Hellwig
2005-08-25 10:41 ` Eric Dumazet
2005-08-25 11:11 ` Nick Piggin
2005-08-25 12:26 ` Eric Dumazet
2005-08-25 14:51 ` Nick Piggin
2005-08-25 14:56 ` Christoph Hellwig
2005-08-25 15:13 ` Eric Dumazet
2005-08-25 18:19 ` Dipankar Sarma
2005-08-25 18:36 ` Christoph Hellwig
2005-08-26 1:16 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430D8CA3.3030709@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox