From: Zachary Amsden <zach@vmware.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Kumar Gala <galak@freescale.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 00/15] Remove asm/segment.h from low hanging architectures
Date: Thu, 25 Aug 2005 02:24:56 -0700 [thread overview]
Message-ID: <430D8E68.7070303@vmware.com> (raw)
In-Reply-To: <1124920244.13833.6.camel@localhost.localdomain>
Alan Cox wrote:
>On Mer, 2005-08-24 at 11:43 -0500, Kumar Gala wrote:
>
>
>>The following set of patches removes the use and existence of
>>asm/segment.h from the architecture ports
>>
>>
>
>You've broken various things by doing this because some driver code
>rightly or wrongly uses segment.h. That is fine because they shouldn't
>do so. However asm/segment.h isn't supoosed to be removed on
>architectures that use segments- like x86, and x86-64. There it is a
>real arch private file and shouldn't be disappearing.
>
>It shouldn't be leaking into drivers any more (eg mxser.c is an offender
>there)
>
>
Yes, agree totally, i386 _requires_ asm/segment.h. It is used in
low-level trap handling and bootup code from assembly files. In
addition, even parts of userspace on i386 depend on asm/segment.h,
although that is a different beast.
It is a total bug if generic drivers include it, there is simply no
reason to use segment.h unless you have to use segmentation. Ideally,
all includes of segment.h should be confined to architectures that
require it, and limited to either arch/foo or include/asm-foo.
I'm looking at -rc6-mm1, and I see the following bad guys:
./drivers/char/mxser.c:#include <asm/segment.h>
./drivers/char/speakup/speakup_drvcommon.c:#include <asm/segment.h>
/* for put_user_byte */
./drivers/isdn/hisax/hisax.h:#include <asm/segment.h>
./drivers/media/video/adv7170.c:#include <asm/segment.h>
./drivers/media/video/adv7175.c:#include <asm/segment.h>
./drivers/media/video/bt819.c:#include <asm/segment.h>
./drivers/media/video/bt856.c:#include <asm/segment.h>
./drivers/media/video/saa7111.c:#include <asm/segment.h>
./drivers/media/video/saa7114.c:#include <asm/segment.h>
./drivers/media/video/saa7185.c:#include <asm/segment.h>
./drivers/serial/68328serial.c:#include <asm/segment.h>
./drivers/serial/crisv10.c:#include <asm/segment.h>
./drivers/serial/icom.c:#include <asm/segment.h>
./drivers/serial/mcfserial.c:#include <asm/segment.h>
./drivers/video/q40fb.c:#include <asm/segment.h>
./include/linux/isdn.h:#include <asm/segment.h>
./sound/oss/os.h:#include <asm/segment.h>
Zach
next prev parent reply other threads:[~2005-08-25 9:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-24 16:43 [PATCH 00/15] Remove asm/segment.h from low hanging architectures Kumar Gala
2005-08-24 16:47 ` [PATCH 01/15] alpha: remove use of asm/segment.h Kumar Gala
2005-08-24 16:48 ` [PATCH 02/15] arm26: " Kumar Gala
2005-08-24 16:50 ` [PATCH 03/15] arm: " Kumar Gala
2005-08-24 16:52 ` [PATCH 04/15] cris: " Kumar Gala
2005-08-24 16:53 ` [PATCH 05/15] ia64: " Kumar Gala
2005-08-24 20:09 ` Bjorn Helgaas
2005-08-24 22:49 ` Ralf Baechle
2005-08-24 16:54 ` [PATCH 06/15] mips: " Kumar Gala
2005-08-24 17:02 ` Ralf Baechle
2005-08-24 16:55 ` [PATCH 07/15] parisc: " Kumar Gala
2005-08-24 17:14 ` [parisc-linux] " Matthew Wilcox
2005-08-24 17:31 ` Kumar Gala
2005-08-24 16:56 ` [PATCH 08/15] ppc32: " Kumar Gala
2005-08-24 16:56 ` [PATCH 09/15] ppc64: " Kumar Gala
2005-08-24 16:58 ` [PATCH 10/15] s390: " Kumar Gala
2005-08-24 16:59 ` [PATCH 11/15] sh64: " Kumar Gala
2005-08-24 16:59 ` [PATCH 12/15] sh: " Kumar Gala
2005-08-24 17:00 ` [PATCH 13/15] sparc64: " Kumar Gala
2005-08-24 17:01 ` [PATCH 14/15] sparc: " Kumar Gala
2005-08-25 23:19 ` David S. Miller
2005-08-24 17:02 ` [PATCH 15/15] xtensa: " Kumar Gala
2005-08-24 21:50 ` [PATCH 00/15] Remove asm/segment.h from low hanging architectures Alan Cox
2005-08-24 21:35 ` Kumar Gala
2005-08-25 9:24 ` Zachary Amsden [this message]
2005-08-25 9:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430D8E68.7070303@vmware.com \
--to=zach@vmware.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=galak@freescale.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox