Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

John McCutchan
2005-08-25T19:05:37Z

On Thu, 2005-08-25 at 21:03 +0200, Johannes Berg wrote:
> On Thu, 2005-08-25 at 11:54 -0700, George Anzinger wrote:
>
> > I think the best thing is to take idr into user space and emulate the
> > problem usage.
>
> Good plan, I guess. Do you think that's easy?
>
> > To this end, from the log it appears that you _might_ be
> > moving between 0, 1 and 2 entries increasing the number each time. It
> > also appears that the failure happens here:
> > add 1023
> > add 1024
> > find 1024 or is it the remove that fails? It also looks like 1024 got
> > allocated twice. Am I reading the log correctly?
>
> Remove 1024 fails, but add(please make it >1024) seems to return 1024,
> and find(1024) also seems to fail. Well, remove() probably has to
> find(), but I'm not really sure what inotify does (maybe find first, to
> see if it's valid).

Just to clarify, the remove() he is talking about isn't idr_remove, it
is inotify's remove. idr_find() is failing at 1024 which causes
inotify's remove to fail.

--
John McCutchan <ttb@tentacle.dhs.org>