From: Michael Marineau <marineam@engr.orst.edu>
To: Manuel Lauss <mano@roarinelk.homelinux.net>
Cc: Andrew Morton <akpm@osdl.org>,
benh@kernel.crashing.org, Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/3] Radeon acpi vgapost only Rv250 (M9)
Date: Sun, 28 Aug 2005 00:31:01 -0700 [thread overview]
Message-ID: <43116835.4030108@engr.orst.edu> (raw)
In-Reply-To: <43115FC2.30309@roarinelk.homelinux.net>
[-- Attachment #1.1: Type: text/plain, Size: 808 bytes --]
Manuel Lauss wrote:
> Michael Marineau wrote:
>
>> Thses patches resume ATI radeon cards from acpi S3 suspend when using
>> radeonfb by reposting the video bios. This is needed to be able to use
>> S3 when the framebuffer is enabled.
>
>
> These patches break resume from S3 for me. On a vanilla kernel,
> radeonfb comes back fine, with your patches applied, the backlight
> gets turned on (by BIOS I think) and shortly afterwards its turned off
> for good. (Radeon M11 on Sony Vaio)
>
Ok, attached is a patch to only attempt a vga post on Rv250 cards (M9)
which I have in my laptop. I'm guessing cards older than M9 might also
be helped with this patch, but better to be conservative than risk
breaking systems that do work properly.
--
Michael Marineau
marineam@engr.orst.edu
Oregon State University
[-- Attachment #1.2: radeonfb-only-post-R250.patch --]
[-- Type: text/x-patch, Size: 631 bytes --]
Index: linux-2.6.13-rc7/drivers/video/aty/radeon_pm.c
===================================================================
--- linux-2.6.13-rc7.orig/drivers/video/aty/radeon_pm.c
+++ linux-2.6.13-rc7/drivers/video/aty/radeon_pm.c
@@ -2790,7 +2790,8 @@ void radeonfb_pm_init(struct radeonfb_in
#endif /* defined(CONFIG_PM) && defined(CONFIG_PPC_OF) */
#if defined(CONFIG_ACPI) && defined(CONFIG_X86)
- if (rinfo->is_mobility && rinfo->pm_reg) {
+ if (rinfo->is_mobility && rinfo->pm_reg &&
+ rinfo->family == CHIP_FAMILY_RV250) {
rinfo->reinit_func = radeon_reinitialize_vgapost;
rinfo->pm_mode |= radeon_pm_post;
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
next prev parent reply other threads:[~2005-08-28 7:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-28 1:25 [PATCH 0/3] Radeon acpi vgapost Michael Marineau
2005-08-28 1:27 ` [PATCH 1/3] Generic " Michael Marineau
2005-08-28 8:07 ` Pavel Machek
2005-08-28 20:56 ` Jiri Slaby
2005-08-30 10:51 ` Dave Airlie
2005-08-28 1:31 ` [PATCH 2/3] Radeon " Michael Marineau
2005-08-28 1:34 ` [PATCH 3/3] Documentation update for radeonfb Michael Marineau
2005-08-28 5:12 ` [PATCH 0/3] Radeon acpi vgapost Nishanth Aravamudan
2005-08-28 7:44 ` Michael Marineau
2005-08-28 18:08 ` Nishanth Aravamudan
2005-08-28 6:54 ` Manuel Lauss
2005-08-28 7:31 ` Michael Marineau [this message]
2005-08-28 12:50 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43116835.4030108@engr.orst.edu \
--to=marineam@engr.orst.edu \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mano@roarinelk.homelinux.net \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox