From: Grigory Tolstolytkin <gtolstolytkin@dev.rtsoft.ru>
To: linux-kernel@vger.kernel.org
Subject: 8250 serial driver and PM
Date: Mon, 29 Aug 2005 21:55:04 +0400 [thread overview]
Message-ID: <43134BF8.1090706@dev.rtsoft.ru> (raw)
Hi,
I'm working on power management support for a particular ARM based board
and I've got a question:
I want to add a board specific power management for standard uart driver
(serial8250). For this purpose there is a special hook defined in
uart_8250_port structure (drivers/serial/8250.c):
...
> /*
> * We provide a per-port pm hook.
> */
> void (*pm)(struct uart_port *port,
> unsigned int state, unsigned int
old);
...
When driver goes into suspend/resume, serial8250_pm() function is called
and it checks for the hook and executes it if it exists. But I didn't
find a proper way to assign my own function to this hook.
How this hook is supposed to be changed? Is there a way to correctly
initialize it and how it should be done?
Whether it's a good way to initialize it, for example, in
serial8250_isa_init_ports():
...
up->mcr_mask = ~ALPHA_KLUDGE_MCR;
up->mcr_force = ALPHA_KLUDGE_MCR;
up->port.ops = &serial8250_pops;
#ifdef CONFIG_ARCH_XXX
up->pm = pnx4008_uart_pm;
#endif
}
...
Or it's a bad manner?
Any help appreciated,
Thanks,
Grigory.
next reply other threads:[~2005-08-29 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-29 17:55 Grigory Tolstolytkin [this message]
2005-08-31 10:08 ` 8250 serial driver and PM Russell King
2005-08-31 10:57 ` Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43134BF8.1090706@dev.rtsoft.ru \
--to=gtolstolytkin@dev.rtsoft.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox