Re: [patch 1/3] x86_64: Add a notify_die() call to the "no context" part of do_page_fault()

[George Anzinger <george@mvista.com>]

Tom Rini wrote:
> CC: Andi Kleen <ak@suse.de>
> This adds a call to notify_die() in the "no context" portion of
> do_page_fault() as someone on the chain might care and want to do a fixup.
> 
> ---
> 
>  linux-2.6.13-trini/arch/x86_64/mm/fault.c |    4 ++++
>  1 files changed, 4 insertions(+)
> 
> diff -puN arch/x86_64/mm/fault.c~x86_64-no_context_hook arch/x86_64/mm/fault.c
> --- linux-2.6.13/arch/x86_64/mm/fault.c~x86_64-no_context_hook	2005-08-29 11:09:13.000000000 -0700
> +++ linux-2.6.13-trini/arch/x86_64/mm/fault.c	2005-08-29 11:09:13.000000000 -0700
> @@ -514,6 +514,10 @@ no_context:
>  	if (is_errata93(regs, address))
>  		return; 
>  
> +	if (notify_die(DIE_PAGE_FAULT, "no context", regs, error_code, 14,
> +				SIGSEGV) == NOTIFY_STOP)
> +		return;
> +
>  /*
>   * Oops. The kernel tried to access some bad page. We'll have to
>   * terminate things with extreme prejudice.

Please use a more descriptive text than "no context".  This bit of info 
SHOULD be available to the gdb/kgdb user and should indicate why kgdb 
was entered.  It thus should be something like "bad kernel address" or 
"illegal kernel address".
> 
-- 
George Anzinger   george@mvista.com
HRT (High-res-timers):  http://sourceforge.net/projects/high-res-timers/