From: "Thomas Pfeiffer" <pfeiffer@pds.de>
To: Alexey Dobriyan <adobriyan@gmail.com>,
Jesper Juhl <jesper.juhl@gmail.com>
Cc: linux-kernel@vger.kernel.org, isdn4linux@listserv.isdn4linux.de
Subject: Re: [PATCH] isdn_v110 warning fix
Date: Tue, 30 Aug 2005 10:42:20 +0200 [thread overview]
Message-ID: <4314380C.31589.937925@localhost> (raw)
In-Reply-To: <20050830082033.GB12449@mipter.zuzino.mipt.ru>
> On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote:
> > drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used uninitialized in this function
>
> > --- linux-2.6.13-orig/drivers/isdn/i4l/isdn_v110.c
> > +++ linux-2.6.13/drivers/isdn/i4l/isdn_v110.c
> > @@ -516,11 +516,11 @@
>
> > -isdn_v110_stat_callback(int idx, isdn_ctrl * c)
> > +isdn_v110_stat_callback(int idx, isdn_ctrl *c)
> > {
> > isdn_v110_stream *v = NULL;
> > int i;
> > - int ret;
> > + int ret = 0;
>
> ret is used only in isdn_v110_stat_callback()::case ISDN_STAT_BSENT.
> It's possible for it to be unused only if passed c->parm.length is 0.
> Do you see codepaths that can do it?
>
initializing ret with the value zero is correct and should be
done.
---------------------------------------------------
Thomas Pfeiffer, PDS - Programm + Datenservice GmbH
email: pfeiffer@pds.de, http://www.pds.de/QFS-BILD
Tel: (49) 4261 855 614, Fax: (49) 4261 855 675
next prev parent reply other threads:[~2005-08-30 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-29 23:05 [PATCH] isdn_v110 warning fix Jesper Juhl
2005-08-30 8:20 ` Alexey Dobriyan
2005-08-30 8:42 ` Thomas Pfeiffer [this message]
2005-08-30 11:25 ` Jesper Juhl
2005-08-30 10:51 ` Karsten Keil
2005-08-30 13:47 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4314380C.31589.937925@localhost \
--to=pfeiffer@pds.de \
--cc=adobriyan@gmail.com \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox