[PATCH] Kconfig: saa7134-dvb must select tda1004x

[PATCH] Kconfig: saa7134-dvb must select tda1004x

[Michael Krufky]

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]

I wish I had seen this before 2.6.13 was released... I guess this only 
goes to show that there haven't been any testers using saa7134-hybrid 
dvb/v4l boards that depend on the tda1004x module, during the 2.6.13-rc 
series :-(

Please apply this to 2.6.14, and also to 2.6.13.1 -stable.  Without this 
patch, users will have to EXPLICITLY select tda1004x in Kconfig.  This 
SHOULD be done automatically when saa7134-dvb is selected.  This patch 
corrects this problem.

saa7134-dvb must select tda1004x

Signed-off-by: Michael Krufky <mkrufky@m1k.net>



[-- Attachment #2: saa7134-dvb-must-select-tda1004x.patch --]
[-- Type: text/plain, Size: 509 bytes --]

 linux/drivers/media/video/Kconfig |    1 +
 1 files changed, 1 insertion(+)

diff -u linux-2.6.13/drivers/media/video/Kconfig linux/drivers/media/video/Kconfig
--- linux-2.6.13/drivers/media/video/Kconfig	2005-08-28 18:41:01.000000000 -0500
+++ linux/drivers/media/video/Kconfig	2005-08-30 14:18:58.116967581 -0500
@@ -254,6 +254,7 @@
 	select VIDEO_BUF_DVB
 	select DVB_MT352
 	select DVB_CX22702
+	select DVB_TDA1004X
 	---help---
 	  This adds support for DVB cards based on the
 	  Philips saa7134 chip.

[2.6 patch] add missing select's to DVB_BUDGET_AV

[Adrian Bunk]

On Tue, Aug 30, 2005 at 03:47:14PM -0400, Michael Krufky wrote:

> I wish I had seen this before 2.6.13 was released... I guess this only 
> goes to show that there haven't been any testers using saa7134-hybrid 
> dvb/v4l boards that depend on the tda1004x module, during the 2.6.13-rc 
> series :-(
> 
> Please apply this to 2.6.14, and also to 2.6.13.1 -stable.  Without this 
> patch, users will have to EXPLICITLY select tda1004x in Kconfig.  This 
> SHOULD be done automatically when saa7134-dvb is selected.  This patch 
> corrects this problem.
>...

What about the patch below fixing the following similar problems in 
drivers/media/dvb/ttpci/budget-ci.c ?

cu
Adrian


<--  snip  -->



Add missing select's to DVB_BUDGET_AV fixing the following compile 
error:

<--  snip  -->

...
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `frontend_init':
budget-av.c:(.text+0xb9448): undefined reference to `tda10046_attach'
budget-av.c:(.text+0xb9518): undefined reference to `tda10021_attach'
drivers/built-in.o: In function `philips_tu1216_request_firmware':
budget-av.c:(.text+0xb937b): undefined reference to `request_firmware'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.13/drivers/media/dvb/ttpci/Kconfig.old	2005-08-31 17:36:33.000000000 +0200
+++ linux-2.6.13/drivers/media/dvb/ttpci/Kconfig	2005-08-31 17:39:57.000000000 +0200
@@ -99,12 +99,15 @@
 config DVB_BUDGET_AV
 	tristate "Budget cards with analog video inputs"
 	depends on DVB_CORE && PCI
 	select VIDEO_DEV
 	select VIDEO_SAA7146_VV
 	select DVB_STV0299
+	select DVB_TDA1004X
+	select DVB_TDA10021
+	select FW_LOADER
 	help
 	  Support for simple SAA7146 based DVB cards
 	  (so called Budget- or Nova-PCI cards) without onboard
 	  MPEG2 decoder, but with one or more analog video inputs.
 
 	  Say Y if you own such a card and want to use it.

Re: [linux-dvb-maintainer] [2.6 patch] add missing select's to DVB_BUDGET_AV

[Johannes Stezenbach]

On Wed, Aug 31, 2005 Adrian Bunk wrote:
> 
> Add missing select's to DVB_BUDGET_AV fixing the following compile 
> error:
> 
> <--  snip  -->
> 
> ...
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `frontend_init':
> budget-av.c:(.text+0xb9448): undefined reference to `tda10046_attach'
> budget-av.c:(.text+0xb9518): undefined reference to `tda10021_attach'
> drivers/built-in.o: In function `philips_tu1216_request_firmware':
> budget-av.c:(.text+0xb937b): undefined reference to `request_firmware'
> make: *** [.tmp_vmlinux1] Error 1
> 
> <--  snip  -->
> 
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Acked-by: Johannes Stezenbach <js@linuxtv.org>

I also added this to linuxtv.org CVS. But I'm not sure it
is critical enough to put it in stable.

Thanks,
Johannes

> --- linux-2.6.13/drivers/media/dvb/ttpci/Kconfig.old	2005-08-31 17:36:33.000000000 +0200
> +++ linux-2.6.13/drivers/media/dvb/ttpci/Kconfig	2005-08-31 17:39:57.000000000 +0200
> @@ -99,12 +99,15 @@
>  config DVB_BUDGET_AV
>  	tristate "Budget cards with analog video inputs"
>  	depends on DVB_CORE && PCI
>  	select VIDEO_DEV
>  	select VIDEO_SAA7146_VV
>  	select DVB_STV0299
> +	select DVB_TDA1004X
> +	select DVB_TDA10021
> +	select FW_LOADER
>  	help
>  	  Support for simple SAA7146 based DVB cards
>  	  (so called Budget- or Nova-PCI cards) without onboard
>  	  MPEG2 decoder, but with one or more analog video inputs.
>  
>  	  Say Y if you own such a card and want to use it.
> 
> 
> _______________________________________________
> linux-dvb-maintainer mailing list
> linux-dvb-maintainer@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb-maintainer
> 

Re: [linux-dvb-maintainer] [2.6 patch] add missing select's to DVB_BUDGET_AV

[Adrian Bunk]

On Wed, Aug 31, 2005 at 06:59:07PM +0200, Johannes Stezenbach wrote:
> On Wed, Aug 31, 2005 Adrian Bunk wrote:
> > 
> > Add missing select's to DVB_BUDGET_AV fixing the following compile 
> > error:
> > 
> > <--  snip  -->
> > 
> > ...
> >   LD      .tmp_vmlinux1
> > drivers/built-in.o: In function `frontend_init':
> > budget-av.c:(.text+0xb9448): undefined reference to `tda10046_attach'
> > budget-av.c:(.text+0xb9518): undefined reference to `tda10021_attach'
> > drivers/built-in.o: In function `philips_tu1216_request_firmware':
> > budget-av.c:(.text+0xb937b): undefined reference to `request_firmware'
> > make: *** [.tmp_vmlinux1] Error 1
> > 
> > <--  snip  -->
> > 
> > 
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> Acked-by: Johannes Stezenbach <js@linuxtv.org>
> 
> I also added this to linuxtv.org CVS. But I'm not sure it
> is critical enough to put it in stable.

If I were a -stable maintainer, I'd include both patches after they were 
included in Linus' tree and shipped with one -rc or -mm kernel.

But that's not a strong opinion, it's also OK for me if the patches 
don't get included in 2.6.13.x .

> Thanks,
> Johannes
>...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [linux-dvb-maintainer] [2.6 patch] add missing select's to DVB_BUDGET_AV

[Michael Krufky]

Adrian Bunk wrote:

>On Wed, Aug 31, 2005 at 06:59:07PM +0200, Johannes Stezenbach wrote:
>  
>
>>I also added this to linuxtv.org CVS. But I'm not sure it
>>is critical enough to put it in stable.
>>    
>>
>If I were a -stable maintainer, I'd include both patches after they were 
>included in Linus' tree and shipped with one -rc or -mm kernel.
>
>But that's not a strong opinion, it's also OK for me if the patches 
>don't get included in 2.6.13.x .
>  
>
Adrian-

About saa7134-dvb patch, it is already in -mm and the 2.6.13.y stable 
patch queue, but not yet in -git.  Nobody will complain about it when it 
comes time for 2.6.13.1 review, as it was only left out of 2.6.13 by 
accident.  I sent that in, as it is technically part of v4l tree (even 
though it handles DVB code, saa7134-dvb.c is a hybrid v4l file).  This 
is (probably) the reason why JS didn't send an ACK on my patch, but I 
bet Mauro will ACK it when Chris starts the 2.6.13.1-stable review on LKML.

Good looking on the budget_av patch :-) ... I was just about to respond 
to your email before I saw that Johannes already did.  IMHO, I agree 
that your budget_av patch couldn't hurt to go to stable as well, but 
since JS says it isn't critical, I think you might need to lobby to him 
to change his mind.  Personally, I think that both patches should go to 
2.6.13.y -stable, as it IS a behavior correction for Kconfig kernel 
compilation, and without these patches, some users may be left confused 
with supported hardware that won't work (without some googling).  I 
think it is best for user-friendliness to apply these ASAP.

If you choose to send it to stable, feel free to add:

Acked-by: Michael Krufky <mkrufky@linuxtv.org>

...although, since I am not the official maintainer (Johannes is) I 
don't think my ACK matters by much :-(

-MiKE Krufky