public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Terrence Miller <Terrence.Miller@Sun.COM>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Adrian Bunk <bunk@stusta.de>, Michael Matz <matz@suse.de>,
	ak@suse.de, discuss@x86-64.org, linux-kernel@vger.kernel.org
Subject: Re: [discuss] [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline"
Date: Tue, 06 Sep 2005 10:54:06 -0700	[thread overview]
Message-ID: <431DD7BE.7060504@Sun.COM> (raw)
In-Reply-To: <20050905184740.GF7403@devserv.devel.redhat.com>

Jakub Jelinek wrote:
> On Mon, Sep 05, 2005 at 08:00:05PM +0200, Adrian Bunk wrote:
> 
>>It isn't the same, but "static inline" is the correct variant.
>>
>>"extern inline __attribute__((always_inline))" (which is what
>>"extern inline" is expanded to) doesn't make sense.
> 
> 
> It does make sense and is different from
> static inline __attribute__((always_inline)).
> Try:
> static inline __attribute__((always_inline)) void foo (void) {}
> void (*fn)(void) = foo;
> vs.
> extern inline __attribute__((always_inline)) void foo (void) {}
> void (*fn)(void) = foo;
> In the former case, GCC will emit the out of line static copy of foo
> if you take its address, in the latter case either you provide foo
> function by other means, or you get linker error.
> 
> 	Jakub

Another standards complient way of dealing with extern inline is
for every module that requires an address generates its own
global copy and the link_once (or COMDAT) facility is used to eliminate
all but one.

-- 

                              Terrence

        ****************************************************
        | Terrence C. Miller      |  Sun Microsystems      |
        | terrence.miller@Sun.COM |  M.S. MPK16-303        |
        | 650-786-9192            |  16 Network Circle     |
        |                         |  Menlo Park, CA 94025  |
        ****************************************************



  parent reply	other threads:[~2005-09-06 17:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-02 20:31 [2.6 patch] include/asm-x86_64 "extern inline" -> "static inline" Adrian Bunk
2005-09-05  8:52 ` [discuss] " Michael Matz
2005-09-05 18:00   ` Adrian Bunk
2005-09-05 18:47     ` Jakub Jelinek
2005-09-05 19:00       ` Adrian Bunk
2005-09-06  4:38         ` H. Peter Anvin
2005-09-06 17:54       ` Terrence Miller [this message]
2005-09-06 20:23         ` Andi Kleen
2005-09-06 20:32           ` David S. Miller
2005-09-06 20:55           ` Terrence Miller
2005-09-06 21:41             ` Michael Matz
2005-09-07  0:07               ` H. Peter Anvin
2005-09-06 21:49             ` Andi Kleen
2005-09-05 23:25 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=431DD7BE.7060504@Sun.COM \
    --to=terrence.miller@sun.com \
    --cc=ak@suse.de \
    --cc=bunk@stusta.de \
    --cc=discuss@x86-64.org \
    --cc=jakub@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matz@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox