Re: [PATCH] PCI: Unhide SMBus on Compaq Evo N620c

Dmitry Torokhov
2005-09-06T23:01:18Z

On 9/6/05, Lee Revell <rlrevell@joe-job.com> wrote:
> On Tue, 2005-09-06 at 13:39 -0700, Rumen Ivanov Zarev wrote:
> > Trivial patch against 2.6.13 to unhide SMBus on Compaq Evo N620c laptop using
> > Intel 82855PM chipset.
>
> > + } else if (unlikely(dev->subsystem_vendor == PCI_VENDOR_ID_COMPAQ)) {
>
> Should unlikely() be used for cases where the conditional will be true
> iff a specific piece of hardware is present? Seems like we'd always
> lose.
>

I would say that we should definitely not use [un]likely for code that
is executed once during boot.

--
Dmitry