From: Jeff Garzik <jgarzik@pobox.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [SCSI] qla1280: endianess annotations
Date: Wed, 07 Sep 2005 22:13:21 -0400 [thread overview]
Message-ID: <431F9E41.5010701@pobox.com> (raw)
In-Reply-To: <200509080111.j881BbNm032480@hera.kernel.org>
Linux Kernel Mailing List wrote:
> diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
> --- a/drivers/scsi/qla1280.c
> +++ b/drivers/scsi/qla1280.c
> @@ -1546,7 +1546,7 @@ qla1280_return_status(struct response *
> int host_status = DID_ERROR;
> uint16_t comp_status = le16_to_cpu(sts->comp_status);
> uint16_t state_flags = le16_to_cpu(sts->state_flags);
> - uint16_t residual_length = le16_to_cpu(sts->residual_length);
> + uint16_t residual_length = le32_to_cpu(sts->residual_length);
> uint16_t scsi_status = le16_to_cpu(sts->scsi_status);
[...]
> + __le16 status_flags; /* Status flags. */
> + __le16 time; /* Time. */
> + __le16 req_sense_length;/* Request sense data length. */
> + __le32 residual_length; /* Residual transfer length. */
> + __le16 reserved[4];
> uint8_t req_sense_data[32]; /* Request sense data. */
This isn't merely an endian annotation.
Is this a size fix, from 16 to 32, or a typo? If its not a typo,
shouldn't the variable be declared 'uint32_t residual_length'?
Jeff
next parent reply other threads:[~2005-09-08 2:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200509080111.j881BbNm032480@hera.kernel.org>
2005-09-08 2:13 ` Jeff Garzik [this message]
2005-09-08 10:44 ` [SCSI] qla1280: endianess annotations Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=431F9E41.5010701@pobox.com \
--to=jgarzik@pobox.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox