From: Miloslav Trmac <mitr@volny.cz>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: vojtech@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Wistron laptop button driver
Date: Thu, 08 Sep 2005 11:36:15 +0200 [thread overview]
Message-ID: <4320060F.8010704@volny.cz> (raw)
In-Reply-To: <84144f02050907234365616f@mail.gmail.com>
Pekka Enberg wrote:
> On 9/7/05, Miloslav Trmac <mitr@volny.cz> wrote:
>
>>+static int __init map_bios(void)
>>+{
>>+ static const unsigned char __initdata signature[]
>>+ = { 0x42, 0x21, 0x55, 0x30 };
>>+
>>+ void __iomem *base;
>>+ size_t offset;
>>+ uint32_t entry_point;
>>+
>>+ base = ioremap(0xF0000, 0x10000); /* Can't fail */
>
> How come? ioremap can return NULL if, for example, we run out of memory.
Not with these values:
> /*
> * Don't remap the low PCI/ISA area, it's always mapped..
> */
> if (phys_addr >= ISA_START_ADDRESS && last_addr < ISA_END_ADDRESS)
> return (void __iomem *) phys_to_virt(phys_addr);
Mirek
next prev parent reply other threads:[~2005-09-08 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-07 2:19 [PATCH] Wistron laptop button driver Miloslav Trmac
2005-09-08 5:23 ` Andrew Morton
2005-09-08 9:32 ` Miloslav Trmac
2005-09-08 6:43 ` Pekka Enberg
2005-09-08 9:36 ` Miloslav Trmac [this message]
2005-09-25 21:35 ` Miloslav Trmac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4320060F.8010704@volny.cz \
--to=mitr@volny.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox