public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Smietanowski <stesmi@stesmi.com>
To: Mathias Adam <a2@adamis.de>
Cc: linux-kernel@vger.kernel.org, rmk+serial@arm.linux.org.uk
Subject: Re: [PATCH] 8250.c: Fix to make 16C950 UARTs work
Date: Fri, 09 Sep 2005 03:58:29 +0200	[thread overview]
Message-ID: <4320EC45.1080108@stesmi.com> (raw)
In-Reply-To: <20050909013144.GA6660@adamis.de>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mathias Adam wrote:
> Currently serial8250_set_termios() refuses to program a baud rate larger
> than uartclk/16. However the 16C950 supports baud rates up to uartclk/4.
> This worked already with Linux 2.4 so the biggest part of this patch was
> simply taken from there and adapted to 2.6.
> -	unsigned int baud, quot;
> +	unsigned int baud, quot, max_baud;
                                 ^^^^^^^^
> -	baud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16); 
> +	MAX_baud = (up->port.type == PORT_16C950 ? port->uartclk/4 : port->uartclk/16);
        ^^^^^^^^

Did you even compile test this?

// Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32)

iD8DBQFDIOxFBrn2kJu9P78RAnG3AJ9EJKl6q4Q4+jXRdMifvmOEdO+HewCfUPd8
T2qQREDAgUq2C7j9yfaPemQ=
=hGK0
-----END PGP SIGNATURE-----

  reply	other threads:[~2005-09-09  1:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-09  1:31 [PATCH] 8250.c: Fix to make 16C950 UARTs work Mathias Adam
2005-09-09  1:58 ` Stefan Smietanowski [this message]
2005-09-09  2:49   ` Mathias Adam
2005-09-09 10:18     ` Russell King
2005-09-09 14:42       ` Mathias Adam
2005-09-16 12:11       ` Mathias Adam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4320EC45.1080108@stesmi.com \
    --to=stesmi@stesmi.com \
    --cc=a2@adamis.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+serial@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox