From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964923AbVIIPh2 (ORCPT ); Fri, 9 Sep 2005 11:37:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964960AbVIIPh2 (ORCPT ); Fri, 9 Sep 2005 11:37:28 -0400 Received: from mail.dvmed.net ([216.237.124.58]:13454 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S964921AbVIIPh0 (ORCPT ); Fri, 9 Sep 2005 11:37:26 -0400 Message-ID: <4321AC25.8090508@pobox.com> Date: Fri, 09 Sep 2005 11:37:09 -0400 From: Jeff Garzik User-Agent: Mozilla Thunderbird 1.0.6-1.1.fc4 (X11/20050720) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Brett M Russ CC: Greg KH , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Greg KH , linux-pci@atrey.karlin.mff.cuni.cz, Andrew Morton Subject: Re: [PATCH 2.6.13] PCI/libata INTx bug fix References: <20050803204709.8BA0720B06@lns1058.lss.emc.com> <42FBA08C.5040103@pobox.com> <20050812171043.CF61020E8B@lns1058.lss.emc.com> <20050812182253.GA7842@suse.de> <42FD14E9.8060502@pobox.com> <20050812224303.F40A820E94@lns1058.lss.emc.com> <20050815185732.GA15216@kroah.com> <20050815192341.6600220FF7@lns1058.lss.emc.com> <1126218402469@kroah.com> <20050909130440.4E31E271E6@lns1058.lss.emc.com> In-Reply-To: <20050909130440.4E31E271E6@lns1058.lss.emc.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Brett M Russ wrote: > Previous INTx cleanup patch had a bug that was not caught. I found > this last night during testing and can confirm that it is now 100% > working. > > Signed-off-by: Brett Russ > > > Index: linux-2.6.13/drivers/pci/pci.c > =================================================================== > --- linux-2.6.13.orig/drivers/pci/pci.c > +++ linux-2.6.13/drivers/pci/pci.c > @@ -764,7 +764,7 @@ pci_intx(struct pci_dev *pdev, int enabl > } > > if (new != pci_command) { > - pci_write_config_word(pdev, PCI_COMMAND, pci_command); > + pci_write_config_word(pdev, PCI_COMMAND, new); If GregKH doesn't pick this up, I'll send it to Andrew/Linus ASAP. libata is the only user currently, and we definitely need this fix. Jeff