Re: [PATCH] bogus #if (acpi/blacklist)

Randy.Dunlap
2005-09-22T05:14:28Z

On Thu, 15 Sep 2005 18:05:15 -0400 Len Brown wrote:

> On Fri, 2005-09-09 at 12:55 -0400, Roman Zippel wrote:
> > Hi,
> >
> > On Fri, 9 Sep 2005 viro@ZenIV.linux.org.uk wrote:
> >
> > > Sigh... It should be left as #if, of course, but I suspect that
> > cleaner way to
> > > deal with that would be (in Kconfig)
> > >
> > > config ACPI_BLACKLIST_YEAR
> > > int "Disable ACPI for systems before Jan 1st this year" if
> > X86
> > > default 0
> >
> > That would be indeed the better fix.
>
> The real bug is that drivers/acpi/blacklist.c (the only place
> CONFIG_ACPI_BLACLIST_YEAR is referenced) is compiled for non X86.

You want this then?
---

From: Randy Dunlap <rdunlap@xenotime.net>

Only build drivers/acpi/blacklist.o on X86 (includes X86_64).

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---

drivers/acpi/Makefile | 2 ++
1 files changed, 2 insertions(+)

diff -Naurp linux-2614-rc2/drivers/acpi/Makefile~blacklist_x86 linux-2614-rc2/drivers/acpi/Makefile
--- linux-2614-rc2/drivers/acpi/Makefile~blacklist_x86 2005-09-21 22:11:23.000000000 -0700
+++ linux-2614-rc2/drivers/acpi/Makefile 2005-09-21 22:11:41.000000000 -0700
@@ -16,7 +16,9 @@ EXTRA_CFLAGS += $(ACPI_CFLAGS)
# ACPI Boot-Time Table Parsing
#
obj-y += tables.o
+ifdef CONFIG_X86
obj-y += blacklist.o
+endif

#
# ACPI Core Subsystem (Interpreter)

---