From: Luben Tuikov <luben_tuikov@adaptec.com>
To: nish.aravamudan@gmail.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2.6.13 9/14] sas-class: sas_expander.c Expander discovery and configuration
Date: Fri, 09 Sep 2005 16:11:49 -0400 [thread overview]
Message-ID: <4321EC85.6080808@adaptec.com> (raw)
In-Reply-To: <29495f1d050909130525f13c7a@mail.gmail.com>
On 09/09/05 16:05, Nish Aravamudan wrote:
> On 9/9/05, Luben Tuikov <luben_tuikov@adaptec.com> wrote:
>
>>Signed-off-by: Luben Tuikov <luben_tuikov@adaptec.com>
>
>
> <snip>
>
>
>>--- linux-2.6.13-orig/drivers/scsi/sas-class/sas_expander.c 1969-12-31 19:00:00.000000000 -0500
>>+++ linux-2.6.13/drivers/scsi/sas-class/sas_expander.c 2005-09-09 11:14:29.000000000 -0400
>
>
> <snip>
>
> +static int sas_ex_general(struct domain_device *dev)
>
> <snip>
>
> + set_current_state(TASK_INTERRUPTIBLE);
> + schedule_timeout(5*HZ);
>
> Can you use msleep_interruptible() here? I don't see wait-queues in
> the immediate vicinity. If not, and you're going for the normal -mm
> route (and from there to mainline), can you use
> schedule_timeout_interruptible(), please?
Yes, sure. I don't see why not.
Luben
prev parent reply other threads:[~2005-09-09 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-09 19:41 [PATCH 2.6.13 9/14] sas-class: sas_expander.c Expander discovery and configuration Luben Tuikov
2005-09-09 20:05 ` Nish Aravamudan
2005-09-09 20:11 ` Luben Tuikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4321EC85.6080808@adaptec.com \
--to=luben_tuikov@adaptec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nish.aravamudan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox