From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 964DDC33CAD for ; Mon, 13 Jan 2020 10:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 634C42080D for ; Mon, 13 Jan 2020 10:17:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="GBO0cpTK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728512AbgAMKRs (ORCPT ); Mon, 13 Jan 2020 05:17:48 -0500 Received: from esa3.microchip.iphmx.com ([68.232.153.233]:18174 "EHLO esa3.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbgAMKRs (ORCPT ); Mon, 13 Jan 2020 05:17:48 -0500 Received-SPF: Pass (esa3.microchip.iphmx.com: domain of Tudor.Ambarus@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa3.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="Tudor.Ambarus@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com -exists:%{i}.spf.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa3.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa3.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa3.microchip.iphmx.com; spf=Pass smtp.mailfrom=Tudor.Ambarus@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: vIWTnFFM6h117cfhgT7Tw50qzQp/nYt0yCJvuDYH2ybEW25DnOcUfpls8hzFawAUouwtgsUv/G LZ4WVZ8PeKHaZI2NR0BN0RnA11U28tAeM8aNRyW7QRpf8F45QLqqJ3p4ulgdmxD6tUdjxqGXFB u0Jr5guBxLhbB0ub9/LHz6p/Q/OL9ht5V6ruBXJzA4mtOsEJjN+lNBcFQ9W1eExPvkJ295MEk/ dW9kWPspyi1E2dCFFSv2Zqh0egurpuv/XDTO/C8YE3ayxAnrNoqDdSscw4za2WoaCFGZZgYnDw efw= X-IronPort-AV: E=Sophos;i="5.69,428,1571727600"; d="scan'208";a="63049100" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Jan 2020 03:17:46 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 13 Jan 2020 03:17:46 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 13 Jan 2020 03:17:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dzb3I3GTOzuM7IaP0k8cU3bR9ESE8r2cMbpTs7MzsNDVCJwr17H/jJidTo9gsmXf+EYbmtoJxKVCRCWzLjn/qykrG7OJaY9Hhna3732LnV4gyfel3VqCKo6s8phFuqwkItOUbrSVrYAFGqO9dOeOovGy3WL2UsWo89RGOGxN9UL4/6k5Q7+fNM+3eUXYB95JnSUG5jDaajg41lladchwvApWqNf+UQ0dbODqx7VTwUrqSukC9dpUB3tgtpqrK0di4vhVeTU/NGmadJ8hF+zzTBoFQdZN1FZXce2I7A+CexvWeGY3VOXpEe5Eowbs+hHsp+4T43EBTLdT4BPMMqCS3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UhI20TNRgwf4GK0Htr2IjMmlwgW22gFtlJ0hp/8ESgI=; b=H3rSL75LM/ozfpHMyWBfiYP4Sb62Cuo6mG4jKQ7oOqUAG2a807rtD/5x/085yf+zG3BY12sJgCQL/1Q0nSCE42+udpNUX4x77f8UQxh0V6syqjn28o8x9orcBWikoDvJUK4TW57ORybd6FZ2XCkjMkHBlODPHRfdlhq6DN9d3n3ikjQwHyb8FRQJBFKsmD4/dHgrJXestbxk8/kh9dCZTBGVNEkuNVPxCJxvP20+Cj1mDpNC/YCliSiJElXiryiEMkbp6NqKkzk97SmevfzqnWIcGO9bJy76yYeTNGvWwOwomxkfIywIZ1LSBHjOwYQOz/X6do2prvDJSNH7PGYRBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UhI20TNRgwf4GK0Htr2IjMmlwgW22gFtlJ0hp/8ESgI=; b=GBO0cpTKTYDbWrZ4ByLm4xDFET2zL4cYZvXAIXYE2ZAWD1XclfoThhOv4C1FVoggDs60h4bNTOz2RFQ8KSHE//0RQ1CEe/FYOVJeFWWfkA2ZwI6ne50pVIt6QvbVLP5jc86pRwp1In0lmZ9TXnoRtb5OAMrmhIJUE5rnpN0j1+w= Received: from MN2PR11MB4448.namprd11.prod.outlook.com (52.135.39.157) by MN2PR11MB4303.namprd11.prod.outlook.com (52.135.37.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Mon, 13 Jan 2020 10:17:44 +0000 Received: from MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::71cc:a5d4:8e1a:198b]) by MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::71cc:a5d4:8e1a:198b%7]) with mapi id 15.20.2623.015; Mon, 13 Jan 2020 10:17:43 +0000 From: To: CC: , , , Subject: Re: [PATCH] mtd: spi-nor: Fix selection of 4-byte addressing opcodes on Spansion Thread-Topic: [PATCH] mtd: spi-nor: Fix selection of 4-byte addressing opcodes on Spansion Thread-Index: AQHVyfqx7b4WTBnS4UypfxmdSedmUg== Date: Mon, 13 Jan 2020 10:17:43 +0000 Message-ID: <4323032.MiQHyusyOz@localhost.localdomain> References: <20200108051343.1939-1-vigneshr@ti.com> In-Reply-To: <20200108051343.1939-1-vigneshr@ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [94.177.32.156] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7eb70763-b3cb-4967-f68c-08d79811d445 x-ms-traffictypediagnostic: MN2PR11MB4303: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1303; x-forefront-prvs: 028166BF91 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39850400004)(396003)(366004)(136003)(346002)(376002)(199004)(189003)(66476007)(478600001)(86362001)(53546011)(6506007)(9686003)(76116006)(6916009)(91956017)(6512007)(4326008)(66946007)(26005)(64756008)(66446008)(66556008)(186003)(6486002)(5660300002)(8676002)(81166006)(81156014)(71200400001)(8936002)(54906003)(316002)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR11MB4303;H:MN2PR11MB4448.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fRcFlir0gucGwiaD6L7gQwt3eLjGRPAFmCoBKNmF5uNATFvCfai0H4CQAWKf5WNg6jQkhLlwenqKqrEFcbojFeYQEs4fo0JtT3VQhaA8fS29sJgXNOBsCVk2ld68TOMtuTIKFt45dnfcNVxr+JuLkjXRdJuAG50DRMuWAtgPWzpeGNoESr58tTkX3X3C88B9AKdejLqncwhMb6PqDsaYq/EdNntxdipqlq3QcwIJ4cvnGevRLguEkimNzgucZ/IMqOXUtjPa8jcxbr0+SoWBmqUDJjzVg/stJs0JR9aTqPi6o88VU41cqwkmXxSoXbisdF8Ynq1WhairTsAjT2NEEaZbvESQ5xns0jhKy82mx+MxTDy4hTSZVYdJxYSrjq0gRBacBhl9oiSm35w/FYUy5tyY/7vXzVQPQNzV8FMBPd2ojOzyj8DOGJCSuK1ZGBrf x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <5D3AA406E295F449901DD33A7A5C4971@namprd11.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7eb70763-b3cb-4967-f68c-08d79811d445 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 10:17:43.6866 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fj9NuUbEqsIAjkAbI5QvLC8iJnedM0wOXHGyw1hd4X7ZqasdGlYf6/z5OpRxer8S7oAWvOoQVzd7GaEsP6nwc5k9EatovfXgQnov0XONZeQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4303 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Vignesh, On Wednesday, January 8, 2020 7:13:43 AM EET Vignesh Raghavendra wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know th= e > content is safe >=20 > mtd->size is still unassigned when running spansion_post_sfdp_fixups() > hook, therefore use nor->params.size to determine the size of flash devic= e. >=20 > This makes sure that 4-byte addressing opcodes are used on Spansion > flashes that are larger than 16MiB and don't have SFDP 4BAIT table > populated. >=20 > Fixes: 92094ebc385e ("mtd: spi-nor: Add spansion_post_sfdp_fixups()") > Signed-off-by: Vignesh Raghavendra This fixes a recent bug, so if you want to take it through mtd/fixes you ca= n=20 add: Reviewed-by: Tudor Ambarus If you want this through spi-nor/next, please let me know and I'll queue it= . Cheers, ta > --- > drivers/mtd/spi-nor/spi-nor.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.= c > index 1082b6bb1393..cd47f07deff3 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -4783,9 +4783,7 @@ static void spi_nor_info_init_params(struct spi_nor > *nor) >=20 > static void spansion_post_sfdp_fixups(struct spi_nor *nor) > { > - struct mtd_info *mtd =3D &nor->mtd; > - > - if (mtd->size <=3D SZ_16M) > + if (nor->params.size <=3D SZ_16M) > return; >=20 > nor->flags |=3D SNOR_F_4B_OPCODES; > -- > 2.24.1