public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Manuel Lauss <mano@roarinelk.homelinux.net>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.13-mm2
Date: Sun, 11 Sep 2005 04:21:41 +0800	[thread overview]
Message-ID: <43234055.6060406@gmail.com> (raw)
In-Reply-To: <4322E3A3.5010903@roarinelk.homelinux.net>

Manuel Lauss wrote:
> 
>> Ah, yes, sorry about that.  Can you try this patch?
>>
>> Fix kernel oops when CONFIG_FB_I810_I2C is set to 'n'.
>>
>> Signed-off-by: Antonino Daplas <adaplas@pol.net>
>>
>> diff --git a/drivers/video/i810/i810_main.c
>> b/drivers/video/i810/i810_main.c
>> --- a/drivers/video/i810/i810_main.c
>> +++ b/drivers/video/i810/i810_main.c
>> @@ -1830,7 +1830,7 @@ static void __devinit i810fb_find_init_m
>>  {
>>      struct fb_videomode mode;
>>      struct fb_var_screeninfo var;
>> -    struct fb_monspecs *specs = NULL;
>> +    struct fb_monspecs *specs = &info->monspecs;
>>      int found = 0;
>>  #ifdef CONFIG_FB_I810_I2C
>>      int i;
>> @@ -1853,12 +1853,11 @@ static void __devinit i810fb_find_init_m
>>      if (!err)
>>          printk("i810fb_init_pci: DDC probe successful\n");
>>  
>> -    fb_edid_to_monspecs(par->edid, &info->monspecs);
>> +    fb_edid_to_monspecs(par->edid, specs);
>>  
>> -    if (info->monspecs.modedb == NULL)
>> +    if (specs->modedb == NULL)
>>          printk("i810fb_init_pci: Unable to get Mode Database\n");
>>  
>> -    specs = &info->monspecs;
>>      fb_videomode_to_modelist(specs->modedb, specs->modedb_len,
>>                   &info->modelist);
>>      if (specs->modedb != NULL) {
> 
> Thanks, it boots now, but doesnt set video mode. Spews
> a bunch of "i810fb: invalid video mode" lines and defaults
> to 640x480.

Set CONFIG_FB_I810_I2C to n.  Your display does not have an EDID block.
Even getting the EDID from the BIOS failed.

Tony

  reply	other threads:[~2005-09-10 20:22 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-08 12:30 2.6.13-mm2 Andrew Morton
2005-09-08 13:12 ` 2.6.13-mm2 Benoit Boissinot
2005-09-08 13:48 ` 2.6.13-mm2 Christoph Hellwig
2005-09-08 14:30 ` 2.6.13-mm2 Martin J. Bligh
2005-09-09  0:39   ` 2.6.13-mm2 Andi Kleen
2005-09-09 10:41     ` 2.6.13-mm2 Andrew Morton
2005-09-09 10:46       ` 2.6.13-mm2 Andi Kleen
2005-09-08 15:11 ` 2.6.13-mm2 high memory support borken? Michal Piotrowski
2005-09-09  9:29   ` Andrew Morton
2005-09-08 17:20 ` 2.6.13-mm2 Michael Thonke
2005-09-08 19:39   ` 2.6.13-mm2 Andrew Morton
2005-09-10  7:02     ` 2.6.13-mm2 Michael Thonke
2005-09-09  1:47 ` 2.6.13-mm2 Grant Coady
2005-09-09  9:43   ` 2.6.13-mm2 Andrew Morton
2005-09-09 13:45     ` 2.6.13-mm2 Grant Coady
2005-09-10  6:33       ` 2.6.13-mm2 Marko Kohtala
2005-09-09  2:52 ` 2.6.13-mm2 - drivers/char/speakup/speakup doesn't compile (+warnings from other things) Damir Perisa
2005-09-09 12:18   ` Alan Cox
2005-09-09 20:57 ` 2.6.13-mm2 (general protection fault) Dominik Karall
2005-09-10 11:45 ` 2.6.13-mm2 Manuel Lauss
2005-09-10 12:42   ` 2.6.13-mm2 Antonino A. Daplas
2005-09-10 13:46     ` 2.6.13-mm2 Manuel Lauss
2005-09-10 20:21       ` Antonino A. Daplas [this message]
2005-09-10 21:26       ` 2.6.13-mm2 Antonino A. Daplas
2005-09-10 18:43 ` 2.6.13-mm2 Dominik Karall
2005-09-10 22:12   ` 2.6.13-mm2 Andrew Morton
2005-09-10 23:46 ` 2.6.13-mm2 J.A. Magallon
2005-09-10 23:56   ` 2.6.13-mm2 Andrew Morton
2005-09-11  0:07     ` 2.6.13-mm2 Patrick McHardy
2005-09-11  0:49       ` 2.6.13-mm2 J.A. Magallon
2005-09-11  0:58         ` 2.6.13-mm2 J.A. Magallon
2005-09-11  1:03           ` 2.6.13-mm2 Patrick McHardy
2005-09-11  1:22             ` 2.6.13-mm2 J.A. Magallon
2005-09-11  1:25               ` 2.6.13-mm2 Patrick McHardy
2005-09-11 17:03 ` 2.6.13-mm2 Rafael J. Wysocki
2005-09-11 19:36   ` 2.6.13-mm2 Andrew Morton
2005-09-11 20:03     ` 2.6.13-mm2 Hugh Dickins
2005-09-12 19:19       ` 2.6.13-mm2 Rafael J. Wysocki
2005-09-11 20:08     ` 2.6.13-mm2 Daniel Ritz
2005-09-12 10:04       ` 2.6.13-mm2 Rafael J. Wysocki
2005-09-12 10:06       ` 2.6.13-mm2 Rafael J. Wysocki
2005-09-12 10:09         ` 2.6.13-mm2 Rafael J. Wysocki
2005-09-18 21:49           ` 2.6.13-mm2 Daniel Ritz
2005-09-19  3:07             ` 2.6.13-mm2 Hugh Dickins
2005-09-19 15:56               ` 2.6.13-mm2 Daniel Ritz
2005-09-23 16:52             ` 2.6.13-mm2 Rafael J. Wysocki
2005-09-28 20:05               ` 2.6.13-mm2 Daniel Ritz
2005-09-28 20:23                 ` [linux-usb-devel] 2.6.13-mm2 David Brownell
2005-09-28 20:37                   ` Rafael J. Wysocki
2005-09-28 20:56                     ` David Brownell
2005-09-28 21:34                       ` Rafael J. Wysocki
2005-09-28 22:04                         ` David Brownell
2005-09-28 22:32                           ` Daniel Ritz
2005-09-29  0:09                             ` David Brownell
2005-09-29 15:36                               ` Linus Torvalds
2005-09-29 16:31                                 ` David Brownell
2005-09-29 19:39                                 ` Daniel Ritz
2005-09-30 16:33                               ` Linus Torvalds
2005-09-30 17:48                                 ` David Brownell
2005-09-29  2:54                             ` Alan Stern
2005-09-28 20:45                   ` Daniel Ritz
2005-09-28 21:07                     ` David Brownell
2005-09-28 21:47                       ` Rafael J. Wysocki
2005-09-28 22:07                       ` Daniel Ritz
2005-09-28 21:10                     ` Alan Stern
2005-09-29 15:22                 ` 2.6.13-mm2 Linus Torvalds
2005-09-12  3:07 ` 2.6.13-mm2 Martin J. Bligh
2005-09-12  5:01   ` 2.6.13-mm2 Andi Kleen
2005-09-12  6:09     ` 2.6.13-mm2 Martin J. Bligh
2005-09-12  7:16       ` 2.6.13-mm2 Andi Kleen
2005-09-12 18:06     ` 2.6.13-mm2 Martin J. Bligh
2005-09-12 18:19       ` 2.6.13-mm2 Dave Hansen
2005-09-12 18:51       ` 2.6.13-mm2 Andi Kleen
2005-09-12 22:46         ` 2.6.13-mm2 Martin J. Bligh
2005-09-13  0:08           ` 2.6.13-mm2 Andrew Morton
2005-09-13  4:00             ` 2.6.13-mm2 Martin J. Bligh
2005-09-12  3:10 ` 2.6.13-mm2 Martin J. Bligh
     [not found] <4KtRD-7Nt-13@gated-at.bofh.it>
2005-09-08 23:23 ` 2.6.13-mm2 Ronny V. Vindenes
2005-09-08 23:34   ` 2.6.13-mm2 Andrew Morton
2005-09-09  0:26     ` 2.6.13-mm2 Parag Warudkar
2005-09-09  0:55       ` 2.6.13-mm2 Roland McGrath
  -- strict thread matches above, loose matches on Subject: below --
2005-09-17  0:36 2.6.13-mm2 Chuck Ebbert
2005-09-17  4:17 ` 2.6.13-mm2 Parag Warudkar
2005-09-17  4:30   ` 2.6.13-mm2 Parag Warudkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43234055.6060406@gmail.com \
    --to=adaplas@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mano@roarinelk.homelinux.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox