Re: [PATCH 10/10] drivers/char: pci_find_device remove (drivers/char/watchdog/i8xx_tco.c)

[Nils Faerber <nils.faerber@kernelconcepts.de>]

Thanks, looks fine to me so I added my signed-off.

Jiri Slaby wrote:
> Cc: nils@kernelconcepts.de [maintainer]
> 
> Jiri Slaby napsal(a):
> 
>> Signed-off-by: Jiri Slaby <xslaby@fi.muni.cz>

Signed-off-by: Nils Faerber <nils@kernelconcepts.de>

>> i8xx_tco.c |    5 +++--
>> 1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/char/watchdog/i8xx_tco.c
>> b/drivers/char/watchdog/i8xx_tco.c
>> --- a/drivers/char/watchdog/i8xx_tco.c
>> +++ b/drivers/char/watchdog/i8xx_tco.c
>> @@ -414,12 +414,11 @@ static unsigned char __init i8xx_tco_get
>>      *      Find the PCI device
>>      */
>>
>> -    while ((dev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev)) !=
>> NULL) {
>> +    for_each_pci_dev(dev)
>>         if (pci_match_id(i8xx_tco_pci_tbl, dev)) {
>>             i8xx_tco_pci = dev;
>>             break;
>>         }
>> -    }
>>
>>     if (i8xx_tco_pci) {
>>         /*
>> @@ -535,6 +534,8 @@ static void __exit watchdog_cleanup (voi
>>     misc_deregister (&i8xx_tco_miscdev);
>>     unregister_reboot_notifier(&i8xx_tco_notifier);
>>     release_region (TCOBASE, 0x10);
>> +
>> +    pci_dev_put(i8xx_tco_pci);
>> }
>>
>> module_init(watchdog_init);
>>  
>>
> 

Cheers
  nils faerber

-- 
kernel concepts          Tel: +49-271-771091-12
Dreisbachstr. 24         Fax: +49-271-771091-19
D-57250 Netphen          Mob: +49-176-21024535
--