Re: [GIT PATCH] More PCI patches for 2.6.13

[Jeff Garzik <jgarzik@pobox.com>]

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

Linus Torvalds wrote:
> Case closed. 
> 
> Bogus warnings are a _bad_ thing. They cause people to write buggy code.
> 
> That drivers/pci/pci.c code should be simplified to not look at the error
> return from pci_set_power_state() at all. Special-casing EIO is just
> another bug waiting to happen.

As a tangent, the 'foo is deprecated' warnings for pm_register() and 
inter_module_register() annoy me, primarily because they never seem to 
go away.

The only user of inter_module_xxx is CONFIG_MTD -- thus the deprecated 
warning is useless to 90% of us, who will never use MTD.  As for 
pm_register(), there are tons of users remaining.  As such, for the 
forseeable future, we will continue to see pm_register() warnings and 
ignore them -- thus they are nothing but useless build noise.

I've attached a patch, just tested, which addresses inter_module_xxx by 
making its build conditional on the last remaining user.  This solves 
the deprecated warning problem for most of us, and makes the kernel 
smaller for most of us, at the same time.

	Jeff



[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 985 bytes --]

diff --git a/kernel/Makefile b/kernel/Makefile
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -6,7 +6,7 @@ obj-y     = sched.o fork.o exec_domain.o
 	    exit.o itimer.o time.o softirq.o resource.o \
 	    sysctl.o capability.o ptrace.o timer.o user.o \
 	    signal.o sys.o kmod.o workqueue.o pid.o \
-	    rcupdate.o intermodule.o extable.o params.o posix-timers.o \
+	    rcupdate.o extable.o params.o posix-timers.o \
 	    kthread.o wait.o kfifo.o sys_ni.o posix-cpu-timers.o
 
 obj-$(CONFIG_FUTEX) += futex.o
@@ -32,6 +32,13 @@ obj-$(CONFIG_GENERIC_HARDIRQS) += irq/
 obj-$(CONFIG_CRASH_DUMP) += crash_dump.o
 obj-$(CONFIG_SECCOMP) += seccomp.o
 
+ifeq ($(CONFIG_MTD),y)
+obj-y += intermodule.o
+endif
+ifeq ($(CONFIG_MTD),m)
+obj-y += intermodule.o
+endif
+
 ifneq ($(CONFIG_SCHED_NO_NO_OMIT_FRAME_POINTER),y)
 # According to Alan Modra <alan@linuxcare.com.au>, the -fno-omit-frame-pointer is
 # needed for x86 only.  Why this used to be enabled for all architectures is beyond