Re: [PATCH] drivers/char/isicom old api rewritten (round 2)

Andrew Morton
2005-09-11T22:21:18Z

Jiri Slaby <jirislaby@gmail.com> wrote:
>
> Andrew Morton wrote:
>
> >Jiri Slaby <jirislaby@gmail.com> wrote:
> >
> >
> >>This patch removes old api in pci probing and replaces it with new.
> >> Firmware loading added.
> >>
> >>
> >> Patch is here for its size (40 KiB):
> >> http://www.fi.muni.cz/~xslaby/lnx/isi_main.txt
> >>
> >>
> >
> >40k isn't large - please include such patches in the email.
> >
> >
> Thank you, Andrew, for your reply and hints, you sent.
>

Did everything get addressed?

>
> Signed-off-by: Jiri Slaby <xslaby@fi.muni.cz>
>
> drivers/char/isicom.c | 2005
> ++++++++++++++++++++++++-------------------------
> include/linux/isicom.h | 53 -
> 2 files changed, 1004 insertions(+), 1054 deletions(-)

Please fix your email client's wordwrapping problem.

> Now, it is 80k:
>
> http://www.fi.muni.cz/~xslaby/lnx/isicom.txt

Then send the patch, cc'ed to the mailing list as per
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, thanks.