Nishanth Aravamudan wrote:

>
>I don't think the embedded folks are going to be ok with adding a 64-bit
>div in the poll() common-path... But otherwise the patch looks pretty
>sane, except I think you want s64, not int64_t? I can't ever remember
>myself :)
>  
>

Oops, I missed an include which is required.  The updated patch is attached.

A 64 bit quantity divided by a 32 bit quantity seems to be a standard
interface in the kernel and is used fairly widely, so I suspect that
the embedded folks have already done the work.

I don't know which should be used, s64 or int64_t.  I chose int64_t
because then it would (more or less) match the interface of do_div().

>I agree the interface mght be mis-defined. And changing timeout_msecs()
>to an integer is consistent with the size of millisecond-unit variables
>used elsewhere in the kernel.
>

Yes, it also makes the kernel definition for sys_poll() match the user level
definition for poll(2) found in <poll.h>.

    Thanx...

       ps

Signed-off-by: Peter Staubach <staubach@redhat.com>