Re: [1/3] Add 4GB DMA32 zone

Roman Zippel
2005-09-12T13:01:53Z

Hi,

On Mon, 12 Sep 2005, Andi Kleen wrote:

> > On Mon, 12 Sep 2005, Andi Kleen wrote:
> > > > > -#define MAX_NR_ZONES 3 /* Sync this with ZONES_SHIFT */
> > > > > -#define ZONES_SHIFT 2 /* ceil(log2(MAX_NR_ZONES)) */
> > > > > +#define MAX_NR_ZONES 4 /* Sync this with ZONES_SHIFT */
> > > > > +#define ZONES_SHIFT 3 /* ceil(log2(MAX_NR_ZONES)) */
> > > >
> > > > Why needs ZONES_SHIFT to be increased?
> > > >
> > > > > -#define FLAGS_RESERVED 8
> > > > > +#define FLAGS_RESERVED 9
> > > >
> > > > I would prefer to keep this at 8.
> > >
> > > sparsemem needs these two.
> >
> > What two? What are you talking about???
>
> The two changes you quoted.

Sorry, but I still don't see why. Could you _please_ be a little more
verbose? Thanks.

bye, Roman