Re: [1/3] Add 4GB DMA32 zone

Roman Zippel
2005-09-13T09:15:51Z

Hi,

On Mon, 12 Sep 2005, Andi Kleen wrote:

> > On Sun, 11 Sep 2005, Andi Kleen wrote:
> > > -#define MAX_NR_ZONES 3 /* Sync this with ZONES_SHIFT */
> > > -#define ZONES_SHIFT 2 /* ceil(log2(MAX_NR_ZONES)) */
> > > +#define MAX_NR_ZONES 4 /* Sync this with ZONES_SHIFT */
> > > +#define ZONES_SHIFT 3 /* ceil(log2(MAX_NR_ZONES)) */
> >
> > Why needs ZONES_SHIFT to be increased?
> >
> > > -#define FLAGS_RESERVED 8
> > > +#define FLAGS_RESERVED 9
> >
> > I would prefer to keep this at 8.
>
> sparsemem needs these two.

Did I somehow offend you, that I don't deserve an answer?
The reason for my question is rather simple (and I thought obvious), the
four zone types fit into two bits, so what is sparsemem doing with this
extra bit?

bye, Roman