From: Jiri Slaby <jirislaby@gmail.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/base/class.c: fix swapped memset() arguments
Date: Mon, 12 Sep 2005 20:23:36 +0200 [thread overview]
Message-ID: <4325C7A8.30805@gmail.com> (raw)
In-Reply-To: <20050912135847.GA9673@mipter.zuzino.mipt.ru>
Alexey Dobriyan napsal(a):
>Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>---
>
> drivers/base/class.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>--- linux-vanilla/drivers/base/class.c
>+++ linux-memset/drivers/base/class.c
>@@ -506,7 +506,7 @@ int class_device_add(struct class_device
> kobject_del(&class_dev->kobj);
> goto register_done;
> }
>- memset(attr, sizeof(*attr), 0x00);
>+ memset(attr, 0x00, sizeof(*attr));
> attr->attr.name = "dev";
> attr->attr.mode = S_IRUGO;
> attr->attr.owner = parent->owner;
>
>
Consider use of kzalloc, some of latest git snapshot contains it yet.
Maybe you want to replace all occurences of memset in this source with
that as I took a look.
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@gmail.com ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
prev parent reply other threads:[~2005-09-12 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-12 13:58 [PATCH] drivers/base/class.c: fix swapped memset() arguments Alexey Dobriyan
2005-09-12 18:23 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4325C7A8.30805@gmail.com \
--to=jirislaby@gmail.com \
--cc=adobriyan@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox